fix(lapis): exit the JVM on OutOfMemoryError - #1854
Open
fhennig wants to merge 1 commit into
Open
Conversation
Add `-XX:+ExitOnOutOfMemoryError` as a default JVM option in the container entrypoint. On OOM the JVM otherwise stays up in a degraded, GC-thrashing state and keeps failing requests until someone restarts it manually (a recent incident left an instance unresponsive for ~19 hours). Exiting lets the orchestrator restart the container. The option is still overridable through the JVM_OPTS environment variable. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5mqrj8VN12QZfxqGNEb1d
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Complete issue #1848’s remaining requirements or narrow the PR’s issue linkage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds fail-fast JVM behavior so LAPIS containers restart after an OutOfMemoryError.
Changes:
- Enables
-XX:+ExitOnOutOfMemoryErrorby default. - Preserves overrides through
JVM_OPTS.
File summaries
| File | Description |
|---|---|
lapis/entrypoint.sh |
Adds the OOM-exit option, but does not fulfill issue #1848’s heap-dump and explicit heap-limit requirements. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
-XX:+ExitOnOutOfMemoryErroras a default JVM option in the container entrypoint. On OOM the JVM otherwise stays up in a degraded, GC-thrashing state and keeps failing requests until someone restarts it manually (a recent incident left an instance unresponsive for ~19 hours). Exiting lets the orchestrator restart the container.The option is still overridable through the JVM_OPTS environment variable.
resolves #1848
PR Checklist
llms.txt.