fix(lapis): expire siloQueryCache entries 30h after last access - #1853
Open
fhennig wants to merge 1 commit into
Open
fix(lapis): expire siloQueryCache entries 30h after last access#1853fhennig wants to merge 1 commit into
fhennig wants to merge 1 commit into
Conversation
The query cache was only ever cleared on a SILO data version change, which can be days apart. Add a 30h idle expiry so heap held by one-off queries (e.g. an analytics script sweeping many filter combinations) is released instead of lingering until the next data update. This is a minimal, low-risk step. Bounding the cache by the memory size of its entries instead of by entry count is tracked separately. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5mqrj8VN12QZfxqGNEb1d
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration change is valid and covered by an appropriate test.
Pull request overview
Adds idle expiration to the SILO query cache, preventing one-off query results from persisting until the next data update.
Changes:
- Configures cache entries to expire 30 hours after last access.
- Adds an integration test verifying the expiration policy.
File summaries
| File | Description |
|---|---|
lapis/src/main/resources/application.properties |
Adds the 30-hour idle expiration policy. |
lapis/src/test/kotlin/org/genspectrum/lapis/silo/SiloQueryCacheConfigurationTest.kt |
Verifies the configured expiration duration. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query cache was only ever cleared on a SILO data version change, which can be days apart. Add a 30h idle expiry so heap held by one-off queries (e.g. an analytics script sweeping many filter combinations) is released instead of lingering until the next data update.
This is a minimal, low-risk step. Bounding the cache by the memory size of its entries instead of by entry count is tracked separately.
PR Checklist
llms.txt.