Repository navigation
Conversation
Bead: lin-50 Bead: lin-51 The synthetic bcftools case fails all ten branch assertions before the filter fix.
Bead: lin-50 Bead: lin-51 Keep PASS and unfiltered records in both callers of steps 25, 26b and 44. Require GQ >= 20 in ancient ancestry, including reference blocks. Document changes to counts and keep both output contracts unchanged.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed calls could reach fine ancestry, ancient ancestry and PRS as usable genotypes. A LowQual or RefCall record counted the same as a passing call. Fine ancestry then rewrote every record with FILTER
., so ADMIXTURE, Beagle and RFMix could not see the failure.The fix
Steps 25, 26b and 44 now keep only
FILTER=PASSor.records, in both bash and Nextflow. LowQual and RefCall records stay missing. Unfiltered reference blocks still count as reference.Step 44 also requires
GQ >= 20, reference blocks included. Low or missing GQ stays missing. Decision and reason: step 44 projects one person with smartpcalsqproject, so a doubtful 0/0 pulls the position, while a missing site only drops out. GQ 20 is the same floor step 7 already uses for reference blocks. Steps 25 and 26b keep only the FILTER rule, as the plan asked. A gVCF with no FORMAT/GQ header line now stops step 44 with bcftools' own error. Step 3's DeepVariant gVCF always defines GQ.What changes in the outputs: fine ancestry's genotype and reference counts can fall, so its VCF rule of one reference call in five can refuse an input it used to accept. Ancient ancestry's
sites_used, PCA position and nearest groups can change. PRS can match fewer sites. Output names and formats stay the same.Files beyond the step scripts, modules and their docs:
docs/25-prs.md(it said a gVCF site is missing only when not covered), andscripts/ci/e2e-case-paths.tsvandscripts/ci/e2e-case-times.tsv(one row each to register the new case).How it was checked
tests/e2e/gvcf-pass-gate.shagainst the old callers: https://github.com/geiresx/OwnGenome/blob/a1cb4117/tests/e2e/gvcf-pass-gate.sh . With pinned bcftools 1.24 and synthetic data, all ten extraction branches fail there. Removing a branch in a scratch copy also fails the branch-count check. This red state was run on the box, not in CI.ci-ok, Rust, Lint, Nextflow, Docs, Container Test, Personal data).gvcf-pass-gateyet. The landing E2E run on the final head covers gvcf-pass-gate, ancient-similarity-1, the prs cases and ancestry-fine-grained-1.Part of #411. Claims settled: lin-50, lin-51.