Repository navigation
Conversation
Keep low-share evidence uncertain and show counts in the report note. Preserve the pathogenic threshold and avoid inferring phased alleles or carrier status from read shares. Bead: sv-28
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Red-first evidence for sv-28: the new synthetic BAM suite ran against the unchanged classifier from d4d3d4b before the fix. The three expected-output files were present on this run. It failed on the incorrect benign verdicts and expected notes, not on compilation or missing inputs. Command: The false negatives returned |
The docs site cannot follow a relative link outside its built tree. The strict site check now passes on all 97 pages. Bead: sv-28
…hon on purpose The sv-28 fix makes og str motif write uncertain_motif where the old Python wrote benign_motif, and shadow mode compares bytes with no goldens. A minority-motif input at a flagged locus would fail the shadow call. docs/testing.md no longer lists og str motif among the shadowed tools.
…inority # Conflicts: # CHANGELOG.md
A benign majority of repeat reads could hide pathogenic or unknown motifs. For example, 17 AAAAG reads and 3 AAGGG reads at RFC1 said "the flag is not supported". The same rule could dismiss a pathogenic insert at a dominant FAME locus.
The count now returns
uncertain_motifin these cases. Its note names the unresolved motifs, counts and shares, so the evidence reaches the report. RFC1's note explains that the reads do not resolve either copy. Dominant loci explain that one pathogenic expansion can be sufficient.The 3-read and 20% floors for
pathogenic_motifstay unchanged. Even one pathogenic or unknown read prevents a benign verdict when at least three reads were counted. This keeps weak evidence uncertain without turning a few reads into a pathogenic result. Read shares do not establish carrier status. No output column, file name or verdict name changes.How it was checked
cargo test --locked -p og-bam --no-fail-fast: 54 tests passed, including eight new integration tests and both archived parity suites.cargo clippy --locked -p og-bam --all-targets -- -D warnings,cargo fmt --all --check, andRUSTDOCFLAGS='-D warnings' cargo doc --locked -p og-bam --no-depspassed.a6f0861fe631545a30b896d6ddf7853d5f95d583: Guard, Rust, Lint, Nextflow, Docs, Container Test, Personal data, and Freshness.a6f0861fwas cancelled before any case ran. The aggregate failed only becausee2e-scopeended cancelled (run). The two cases that run the changed code,tests/e2e/expansions-and-rfc1-1-motif.shandtests/e2e/str-catalog-1-strchive.sh, have not run on this code yet. They need the HG002 fixture and the Linux images, so they could not run on the build box. E2E must run on the final head.Decision: keep the existing above-threshold notes and parity outputs. Benign reads can belong to an interrupted allele, so a new carrier inference would overstate the evidence. The three new minority expectations live under tests/parity/want/rfc1/ and are checked by the integration test.
Decision:
og str motifleavesOG_SHADOWin.github/workflows/e2e.yml. Shadow mode compares og with the old Python byte for byte and knows no goldens. After this fix og writesuncertain_motifwhere the Python wrotebenign_motif, so any e2e input with a minority motif at a flagged locus would fail the shadow call. Theoracle.refrow stays: no parity case uses it, and it only feedsscripts/ci/oracle-diff.sh materialise.docs/testing.mdnow says the motif count is not shadowed, and why. These two files are outside the original file list of this change and were added for this reason only.Part of #411. Closes claim sv-28.
CodeRabbit returned a review limit notice, and the shared review queue was still taken after the last push. The independent review stage is the review of record.