Skip to content

build(deps): hold ExpansionHunter at its last Apache-2.0 release - #446

Open
geiresx wants to merge 3 commits into
GeiserX:mainfrom
geiresx:pgp/i411-eh-hold
Open

geiresx wants to merge 3 commits into
GeiserX:mainfrom
geiresx:pgp/i411-eh-hold

Conversation

@geiresx

@geiresx geiresx commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

ExpansionHunter had no Renovate hold, so a future release could be proposed without a licence review. Version 5.0.0 is Apache-2.0, while upstream's default branch uses PolyForm Strict 1.0.0.

Disable Renovate updates for this image in all three pin files. Document the hold in versions.env, the generated versions page and the maintainer guide. The current image stays pinned. No pipeline option, output or format changes.

Decision: hold every update, including Bioconda rebuilds, as Manta already does. A maintainer must read the proposed source and image licences before changing the hold. This avoids relying on a dashboard approval as a licence check.

How it was checked

  • Renovate 44.199.2, Node 24.22.3: strict config validation passed.
  • Red and green lookup controls: local Renovate lookup controls used a simulated Quay registry with newer build, patch, minor and major tags. Without the hold, each control proposed its newer tag in all three files and the no-update assertion failed. With the hold, all three dependencies reported disabled, no updates were proposed and the assertion passed. The registry response was simulated because no later ExpansionHunter release is currently published.
  • scripts/ci/gen-versions-doc.sh --check passed.
  • scripts/ci/gen-containers-config.sh --check passed for all 128 processes. Regenerating it produced no diff.
  • git diff --check passed.

Upstream CI: Guard, Rust, Lint, Nextflow, Docs, Container Test, Personal data, Renovate dry run.

Part of #411. Closes claim/bead lic-32.

@geiresx
geiresx requested a review from GeiserX as a code owner November 15, 2026 17:57
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9078a1d and 0f14a92.

Files selected for processing: 5

  • CHANGELOG.md
  • docs/updating.md
  • docs/versions.md
  • renovate.json
  • versions.env
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@geiresx

geiresx commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator Author

Licence hold controls for 83d931d.

Ran Renovate 44.199.2 with Node 24.22.3, --platform=local --dry-run=lookup. A Nock 14.0.10 fixture replaced Quay responses. All other network access was disabled. Each fixture held the current tag and one hypothetical newer tag. No such newer release is claimed to exist.

The fixture copied the repository's Docker regex manager and all package rules. It kept only ExpansionHunter's three pin lines. Shared presets were removed to avoid unrelated network access. The red configuration was the pre-fix config. The green configuration had the hold.

red rebuild: assertion exit 1, 3/3 pin files proposed 5.0.0--hc26b3af_6
green rebuild: assertion exit 0, 3/3 pin files had no updates, skipReason=disabled
red patch: assertion exit 1, 3/3 pin files proposed 5.0.1--hc26b3af_0
green patch: assertion exit 0, 3/3 pin files had no updates, skipReason=disabled
red minor: assertion exit 1, 3/3 pin files proposed 5.1.0--hc26b3af_0
green minor: assertion exit 0, 3/3 pin files had no updates, skipReason=disabled
red major: assertion exit 1, 3/3 pin files proposed 6.0.0--hc26b3af_0
green major: assertion exit 0, 3/3 pin files had no updates, skipReason=disabled

The same assertion ran against both results. Exit 1 on the pre-fix result was required, so an empty lookup or a failed lookup could not pass as evidence.

Assertion used for each dry-run log
const assert = require('node:assert/strict');
const fs = require('node:fs');
const rows = fs.readFileSync(process.argv[2], 'utf8').split('\n').flatMap(line => {
  try { return [JSON.parse(line)]; } catch { return []; }
});
assert(!rows.some(row => row.level >= 50), 'Renovate logged an error');
const result = rows.find(row => row.msg === 'packageFiles with updates');
assert(result, 'missing Renovate result');
const files = result.config.regex;
assert.equal(files.length, 3, 'must extract all three copies of the pin');
for (const file of files) {
  assert.equal(file.deps.length, 1);
  const dep = file.deps[0];
  assert.equal(dep.depName, 'quay.io/biocontainers/expansionhunter');
  console.log(file.packageFile + ': ' + JSON.stringify({updates:dep.updates,skipReason:dep.skipReason}));
  assert.deepEqual(dep.updates, [], file.packageFile + ' proposes an ExpansionHunter bump');
  assert.equal(dep.skipReason, 'disabled');
}
console.log('PASS: ExpansionHunter is held in all three files');
Registry fixture used for each dry run

Install renovate@44.199.2 and nock@14.0.10 under tooling/ beside registry.cjs. Run Renovate with NODE_OPTIONS="--require /absolute/path/to/registry.cjs", LOG_LEVEL=debug, LOG_FORMAT=json and FIXTURE_NEW_TAG set to each tag listed above. Run the assertion on each log.

const nock = require('./tooling/node_modules/nock');
nock.disableNetConnect();
nock('https://quay.io').persist().get(/.*/).reply((uri) => {
  console.error('FIXTURE GET ' + uri);
  const tags=['5.0.0--hc26b3af_5',process.env.FIXTURE_NEW_TAG || '5.0.1--hc26b3af_0'];
  if(uri.includes('/tags/list')) return [200, {name:'biocontainers/expansionhunter',tags}];
  if(uri.includes('/tag/')) return [200, {tags:tags.map(name=>({name})),has_additional:false}];
  if(uri === '/v2/') return [200, {}];
  return [404, {}];
});

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants