Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Licence hold controls for 83d931d. Ran Renovate 44.199.2 with Node 24.22.3, The fixture copied the repository's Docker regex manager and all package rules. It kept only ExpansionHunter's three pin lines. Shared presets were removed to avoid unrelated network access. The red configuration was the pre-fix config. The green configuration had the hold. The same assertion ran against both results. Exit 1 on the pre-fix result was required, so an empty lookup or a failed lookup could not pass as evidence. Assertion used for each dry-run logconst assert = require('node:assert/strict');
const fs = require('node:fs');
const rows = fs.readFileSync(process.argv[2], 'utf8').split('\n').flatMap(line => {
try { return [JSON.parse(line)]; } catch { return []; }
});
assert(!rows.some(row => row.level >= 50), 'Renovate logged an error');
const result = rows.find(row => row.msg === 'packageFiles with updates');
assert(result, 'missing Renovate result');
const files = result.config.regex;
assert.equal(files.length, 3, 'must extract all three copies of the pin');
for (const file of files) {
assert.equal(file.deps.length, 1);
const dep = file.deps[0];
assert.equal(dep.depName, 'quay.io/biocontainers/expansionhunter');
console.log(file.packageFile + ': ' + JSON.stringify({updates:dep.updates,skipReason:dep.skipReason}));
assert.deepEqual(dep.updates, [], file.packageFile + ' proposes an ExpansionHunter bump');
assert.equal(dep.skipReason, 'disabled');
}
console.log('PASS: ExpansionHunter is held in all three files');Registry fixture used for each dry runInstall const nock = require('./tooling/node_modules/nock');
nock.disableNetConnect();
nock('https://quay.io').persist().get(/.*/).reply((uri) => {
console.error('FIXTURE GET ' + uri);
const tags=['5.0.0--hc26b3af_5',process.env.FIXTURE_NEW_TAG || '5.0.1--hc26b3af_0'];
if(uri.includes('/tags/list')) return [200, {name:'biocontainers/expansionhunter',tags}];
if(uri.includes('/tag/')) return [200, {tags:tags.map(name=>({name})),has_additional:false}];
if(uri === '/v2/') return [200, {}];
return [404, {}];
}); |
ExpansionHunter had no Renovate hold, so a future release could be proposed without a licence review. Version 5.0.0 is Apache-2.0, while upstream's default branch uses PolyForm Strict 1.0.0.
Disable Renovate updates for this image in all three pin files. Document the hold in versions.env, the generated versions page and the maintainer guide. The current image stays pinned. No pipeline option, output or format changes.
Decision: hold every update, including Bioconda rebuilds, as Manta already does. A maintainer must read the proposed source and image licences before changing the hold. This avoids relying on a dashboard approval as a licence check.
How it was checked
disabled, no updates were proposed and the assertion passed. The registry response was simulated because no later ExpansionHunter release is currently published.scripts/ci/gen-versions-doc.sh --checkpassed.scripts/ci/gen-containers-config.sh --checkpassed for all 128 processes. Regenerating it produced no diff.git diff --checkpassed.Upstream CI: Guard, Rust, Lint, Nextflow, Docs, Container Test, Personal data, Renovate dry run.
Part of #411. Closes claim/bead
lic-32.