Repository navigation
Conversation
…peat map The fake-docker cases fail on main: step 04c runs Sniffles2 on a short-read BAM and exits 0, never passes --tandem-repeats, and its closing hint sends long-read SVs to duphold for a GQ. Bead: sv-18 Bead: sv-17
…epeat map Step 04c ran Sniffles2 on any BAM. On short reads Sniffles2 finds no SV and still exits 0, so the step reported success with an empty VCF. It now reads the mean length of the first 10,000 primary reads with the pinned samtools image and stops below 1,000 bp, naming the long-read BAM to use. setup.sh installs GIAB's GRCh38 tandem-repeat stratification (v3.6, NIST data, pinned by sha256) and keeps it unpacked; step 04c passes it as --tandem-repeats when present and says so when not. Sniffles' own file comes from PacBio's pbsv under a licence limited to PacBio data, so it could not serve ONT reads. The closing hint no longer sends long-read SVs to duphold for a GQ: Sniffles2 writes its own, and step 15 reads Manta's calls only. Bead: sv-18 Bead: sv-17 Bead: D14
…l on chrX The SV rows passed on any record within 500 bp of the planted deletion, of any type, size or filter, and nothing caught false calls elsewhere. Sniffles2, Manta, Delly and TIDDIT now need one PASS deletion of 2.7 to 3.3 kb there; Sniffles2 also needs no PASS record elsewhere, and a second row runs it with --tandem-repeats as step 04c does. GRIDSS keeps the loose check: it writes breakends, not DEL records. A new DELLY_IMAGE row runs delly sr --sex male and female on mini.bam moved onto a chrX of GRCh38's length past PAR1 (input chrx): the male genotype must be haploid, the female 1/1, and an unknown value must fail. Delly ignores --sex without a word on a chrX of another length; the row goes red when the chrX is one base longer. The self-test plants records for each rule of the new checks. Bead: sv-43 Bead: sv-41
The long-read guide said duphold re-genotypes SVs and that Sniffles2's QUAL is reliable, and listed SV counts and repeat accuracy with no source. It now says what duphold really reads, describes the read-length check and the tandem-repeat map, and gives the run we measured on a public HG002 HiFi slice next to the Sniffles2 paper. testing.md says what the smoke rows and fake-docker cases cover. Bead: sv-17 Bead: sv-43 Bead: sv-41
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…smoke # Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #411: sv-17, sv-18, sv-41, sv-43, and owner decision D14.
The problem
Step 04c ran Sniffles2 on whatever BAM it was given. Pointed at a short-read BAM, Sniffles2 finds no structural variant and still exits 0. So the step reported success with an empty VCF. Sniffles2 also ran without a tandem-repeat map, which it uses to place breakpoints and merge calls inside repeats. The step's closing hint said duphold adds a GQ to long-read SVs. It does not, and step 15 reads Manta's calls only. The long-read guide repeated that duphold "re-genotypes" SVs and listed SV counts and repeat accuracy with no source.
The tests only checked wiring. The SV smoke rows passed on any record near the planted deletion, of any type, size or filter. No test ran Delly's
--sexoption with the real binary.The fix
aligned_longread/<sample>_sorted.bam). A BAM with no primary read also stops it.setup.shinstalls GIAB's GRCh38 tandem-repeat stratification (v3.6, NIST data, free to reuse), pinned byTANDEM_REPEATS_URLandTANDEM_REPEATS_SHA256inversions.env, and keeps it unpacked asreference/GRCh38_AllTandemRepeats.bed. Step 04c passes it as--tandem-repeatswhen present, and prints a note when not.docs/testing.mdsays what the smoke rows and fake-docker cases cover.--tandem-repeats, as step 04c does. GRIDSS keeps the loose check, because it writes breakends, not deletion records.--sex malethe deletion must be haploid (1), with--sex female1/1, the log must name the sex, and an unknown value must fail. Delly ignores--sexwithout a message on a chrX of any other length.Decisions:
How it was checked
bash-step-sv(step 04c exited 0 on a short-read BAM) andbash-step-partial-outputs(the duphold "GQ scores" hint). https://github.com/GeiserX/OwnGenome/actions/runs/43720408301/job/132830954740image-smoke.sh --self-testplants records for each rule of the new SV checks (a 3 kb insertion, a 60 bp deletion, a filtered deletion, a deletion 2 kb away, a PASS call elsewhere). With the type and filter rules removed from the counter, two self-test cases go red; with the real counter, all pass.1/1and the log names no sex.Beads: sv-17, sv-18, sv-41, sv-43, D14.