Skip to content

ingest: a committed delivery drops the commit_rejected problems - #784

Open
AnikethCheluva wants to merge 1 commit into
aniketh/ingest-key-hygienefrom
aniketh/ingest-committed-clears-problems
Open

AnikethCheluva wants to merge 1 commit into
aniketh/ingest-key-hygienefrom
aniketh/ingest-committed-clears-problems

Conversation

@AnikethCheluva

@AnikethCheluva AnikethCheluva commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Stack context

Follow-ups to the Lance ingest stack (#756–#761, then #770–#780), found while running the whole pipeline end to end on R2 with fake vendors. Stacked on #780: #784 → #785.

Why

After lance_commit --replace commits a delivery that was commit_rejected, the watcher moved it to committed but kept the committer's "already committed" error in problems. The dashboard then counted a problem on a delivery that is in the dataset. The watcher now clears problems when it marks a delivery committed.

Tests

test_restaging_a_committed_recording_waits_for_replace now also checks that problems is empty once the replacement lands. The ingest, Lance and MCAP unit tests pass on rl2-3 (300 passed). The watch tests need ffmpeg with libx264, which the laptop's ffmpeg does not have.

🤖 Generated with Claude Code

After lance_commit --replace commits a delivery that was commit_rejected, the
watcher set it committed but kept "already committed" in its problems, so the
dashboard listed a problem on a delivery that is in the dataset.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant