Repository navigation
ingest: a committed delivery drops the commit_rejected problems - #784
Open
AnikethCheluva wants to merge 1 commit into
Open
AnikethCheluva wants to merge 1 commit into
AnikethCheluva wants to merge 1 commit into
Conversation
After lance_commit --replace commits a delivery that was commit_rejected, the watcher set it committed but kept "already committed" in its problems, so the dashboard listed a problem on a delivery that is in the dataset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack context
Follow-ups to the Lance ingest stack (#756–#761, then #770–#780), found while running the whole pipeline end to end on R2 with fake vendors. Stacked on #780: #784 → #785.
Why
After
lance_commit --replacecommits a delivery that wascommit_rejected, the watcher moved it tocommittedbut kept the committer's "already committed" error inproblems. The dashboard then counted a problem on a delivery that is in the dataset. The watcher now clearsproblemswhen it marks a delivery committed.Tests
test_restaging_a_committed_recording_waits_for_replacenow also checks thatproblemsis empty once the replacement lands. The ingest, Lance and MCAP unit tests pass on rl2-3 (300 passed). The watch tests need ffmpeg with libx264, which the laptop's ffmpeg does not have.🤖 Generated with Claude Code