Skip to content

fix(release): drop --offline from the workspace lockfile sync #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgqqqqq merged 1 commit into from
Aug 21, 2026
Merged

fix(release): drop --offline from the workspace lockfile sync #2423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/set-build-version.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,15 @@ export function setBuildVersion(root, version) {
// invocation. Cargo has to do the rewrite: a text substitution would also catch
// third-party crates that happen to publish the same version string, and would
// miss members that pin a version of their own.
//
// This cannot run with --offline: resolving the workspace walks every source,
// and the git dependencies (tauri) are not in a cold CI cargo home yet.
function syncCargoLock(root) {
if (!existsSync(path.join(root, 'Cargo.lock'))) {
return;
}

const result = spawnSync('cargo', ['update', '--workspace', '--offline'], {
const result = spawnSync('cargo', ['update', '--workspace'], {
cwd: root,
encoding: 'utf8',
});
Expand All @@ -64,7 +67,7 @@ function syncCargoLock(root) {
}
if (result.status !== 0) {
throw new Error(
`cargo update --workspace --offline failed with exit code ${result.status}\n${result.stderr || ''}`,
`cargo update --workspace failed with exit code ${result.status}\n${result.stderr || ''}`,
);
}
}
Expand Down