Skip to content

[1.0.0] Fix control handling and a few protocol edge cases. - #392

Merged
ChadSikorra merged 6 commits into
FreeDSx:mainfrom
ChadSikorra:fix/protocol-controls
Nov 17, 2026
Merged

ChadSikorra merged 6 commits into
FreeDSx:mainfrom
ChadSikorra:fix/protocol-controls

Conversation

@ChadSikorra

@ChadSikorra ChadSikorra commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

This fixes some protocol and control issues:

  • Requests read ahead during a streaming search are now dropped at a StartTLS upgrade.
  • Fixed a SASL bind edge case related to the new request budget.
  • Absolute false searches now run through the normal search path.
  • The assertion control now works on a sync search.
  • A control is only decoded into its type for an operation that supports it.
  • Pre-Read and Post-Read now return back-links properly.

@ChadSikorra
ChadSikorra merged commit 13bb1e3 into FreeDSx:main Nov 17, 2026
14 checks passed
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.31461% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.22%. Comparing base (00fa48e) to head (f7b28e9).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...x/Ldap/Server/Middleware/ServerControlRegistry.php 89.47% 2 Missing ⚠️
...c/FreeDSx/Ldap/Protocol/Decoder/MessageDecoder.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #392      +/-   ##
============================================
+ Coverage     92.17%   92.22%   +0.04%     
  Complexity       29       29              
============================================
  Files           863      866       +3     
  Lines         32543    32675     +132     
============================================
+ Hits          29997    30134     +137     
+ Misses         2546     2541       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant