Repository navigation
feat(settings): add a Show Music switch that hides YouTube Music everywhere - #553
Merged
Merged
Conversation
…Show Music is off
Co-authored-by: Spect_Ops <58440212+Spectra47@users.noreply.github.com>
# Conflicts: # src/components/layout/Sidebar.tsx
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flow://links or a pasted URL, open as the video, the YouTube playlist or the channel. A YouTube Music album has no YouTube page, so its link is ignored.Related issue
Change type
Validation
pnpm test(399 files, 2341 tests, 0 failures)pnpm build(tsc and vite build pass)cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check(clean)cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features(no new warnings; the one changed Rust line adds a key to a list)cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features(74 suites, 1688 passed, 0 failed, 11 ignored)New tests cover the side rail links, music pages leading Home, music links and extension handoffs opening as videos, playback stopping for a YouTube Music song but not a local file, search suggestions not asking YouTube Music, stored music-only searches falling back to All, and songs leaving History, the Library shelves and their tabs. Not run in the app yet.
Screenshots or recordings
Risk and compatibility
No database change. One new setting,
music_content_enabled, default on, synced to other desktops under thedesktop.prefix. With the switch off, Flow makes no YouTube Music requests from search.