Skip to content

feat(settings): add a Show Music switch that hides YouTube Music everywhere - #553

Merged
A-EDev merged 7 commits into
mainfrom
feat/show-music-switch
Nov 10, 2026
Merged

A-EDev merged 7 commits into
mainfrom
feat/show-music-switch

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • A Show Music switch in Settings > Content & UI turns YouTube Music off everywhere, on the model of Show Shorts. It is on by default, and Music Tab is greyed out while it is off.
  • With it off: the side rail has no Music or Albums link, music pages lead Home, search never asks YouTube Music (suggestions, All, Artists and Playlists show YouTube's results only, and Songs, Albums, Podcasts and Episodes are hidden), and the Library, History, Likes and Downloads hide songs, albums and music downloads. Your taste and Recap leave out their music cards, and a video's credited songs are hidden.
  • Music links, from the browser extension, flow:// links or a pasted URL, open as the video, the YouTube playlist or the channel. A YouTube Music album has no YouTube page, so its link is ignored.
  • Turning it off stops a YouTube Music song that is playing, and a saved music queue isn't restored while it is off. Local files still play in the music player, and Settings > Music and Lyrics stay for them.
  • Nothing is deleted: albums, likes, history and the saved queue come back when the switch is turned on again. The setting syncs between desktops only, as Android has no such switch.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test (399 files, 2341 tests, 0 failures)
  • pnpm build (tsc and vite build pass)
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check (clean)
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features (no new warnings; the one changed Rust line adds a key to a list)
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features (74 suites, 1688 passed, 0 failed, 11 ignored)
  • I smoke-tested the affected desktop behavior.

New tests cover the side rail links, music pages leading Home, music links and extension handoffs opening as videos, playback stopping for a YouTube Music song but not a local file, search suggestions not asking YouTube Music, stored music-only searches falling back to All, and songs leaving History, the Library shelves and their tabs. Not run in the app yet.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

No database change. One new setting, music_content_enabled, default on, synced to other desktops under the desktop. prefix. With the switch off, Flow makes no YouTube Music requests from search.

Copilot AI balanced review requested due to automatic review settings November 10, 2026 22:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@A-EDev
A-EDev merged commit fa69456 into main Nov 10, 2026
7 checks passed
@A-EDev
A-EDev deleted the feat/show-music-switch branch November 10, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants