Repository navigation
fix(test): stop the Tauri check from throwing once a test page is gone - #549
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTauriEnv()waits up to 100 ms for Tauri's bridge and readswindowafter each 10 ms pause. When a test file finishes during that wait, jsdom is torn down, the next read throws, and Vitest reports an unhandled rejection that fails the run although every test passed. That is what failed Quality checks on main after fix(i18n): mirror the layout in right-to-left languages and keep foreign titles in order #548 (run 42837153459, started frommusicAudioSettings.test.ts).windowis gone. A co-located test covers it.Related issue
Change type
Validation
pnpm test: 386 files, 2287 tests passed, no unhandled errors. The new test fails without the fix ("promise rejected TypeError") and passes with it.pnpm build: passedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: cleancargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: exit 0 (no Rust changes)cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 1680 passed, 0 failedScreenshots or recordings
Risk and compatibility
No change in the app: inside Tauri
windownever goes away. No changelog entry, since nothing changes for users.No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
User-facing documentation was updated where needed.
Dependency and lockfile changes are intentional and limited to this PR.
Breaking changes and upgrade steps are clearly documented.