Repository navigation
fix(ui): hide the Saved Shorts link while Shorts are hidden - #441
Merged
A-EDev merged 5 commits intoNov 10, 2026
Merged
Conversation
…e disabled - Gate /albums and /saved-shorts sidebar links behind MUSIC_NAVIGATION_ENABLED and SHORTS_NAVIGATION_ENABLED. - Hide Albums, Music downloads, and Saved Shorts shelves on LibraryPage when respective nav toggles are off. - Skip YouTube Music autocomplete and combined search queries/chips when Music navigation is disabled. - Hide Music/Albums filter chips in History and Downloads, and hide Music category in Settings sidebar when Music is disabled.
# Conflicts: # changelog/v0.1.0-beta4.txt # src/components/layout/TopbarSearch.tsx # src/components/search/SearchControlBar.tsx # src/components/settings/SettingsLayout.tsx # src/lib/useSearchSuggestions.ts # src/pages/History.tsx # src/pages/LibraryPage.tsx
Co-authored-by: Spect_Ops <58440212+Spectra47@users.noreply.github.com>
Co-authored-by: Spect_Ops <58440212+Spectra47@users.noreply.github.com>
A-EDev
changed the title
Collaborator
|
Thanks for this, and for writing a test. I narrowed it to one change before merging. The Music Tab and Shorts Tab switches are under Navigation tabs, and as on Android they only hide the tab. Turning one off shouldn't also hide history, downloads, search results or the Music settings section. For Shorts, main got a separate Show Shorts switch in Content after you branched, and it already hides Shorts in search, Library, History and Home. Your PR found one gap that main still had: the side rail kept its Saved Shorts link while Show Shorts was off, even though the Library hides that shelf. The PR now fixes just that, with a test. A Show Music switch that works like Show Shorts is a good idea, so I'm adding one in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Change type
Validation
pnpm test(393 files, 2322 tests, 0 failures)pnpm build(tsc and vite build pass)cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-featurescargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-featuresNo Rust files change. A new Sidebar test checks the link with Show Shorts on and off, and fails without the fix.
Screenshots or recordings
Risk and compatibility