Skip to content

fix(innertube): show the channel name, not the view count, on channel tab cards - #427

Merged
A-EDev merged 8 commits into
Flow-Tube:mainfrom
Captain-Vikram:fix/issue-423-channel-byline-view-count
Nov 10, 2026
Merged

A-EDev merged 8 commits into
Flow-Tube:mainfrom
Captain-Vikram:fix/issue-423-channel-byline-view-count

Conversation

@Captain-Vikram

@Captain-Vikram Captain-Vikram commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Cards from a channel's own Videos tab have no byline row, so the parser took the view count ("1.2M views") as the channel name and lost the view line. That is what Home showed for channels you follow. The first metadata row now counts as the byline only when it holds no count, date or premiere text. A live card with a lone viewer count is read the same way.
  • Channel tab cards take their channel's name and avatar from the page header, as before, now that the name slot is empty.
  • Migration 0046 corrects cards saved before the fix in the subscription store, channel memory, neighbour channels and the Home cache. A card takes the name its channel is known by and gets its count back on its own line. A card with no known channel name is left for the next refetch, and no name is ever blanked. It matches English counts only; refetching fixes other languages.

Related issue

Closes #423

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Documentation
  • Build, packaging, or CI

Validation

  • pnpm test (386 files, 2287 tests, 0 failures)
  • pnpm build (tsc and vite build pass)
  • cargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check (clean)
  • cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features (no warnings in the changed files)
  • cargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features (74 suites, 1686 passed, 0 failed, 11 ignored)
  • I smoke-tested the affected desktop behavior.

New tests: a stats-only row, a live card, a channel named "Studio 54", a lone byline "100D Beatz", the owner claiming a card, and the repair on seeded rows. The migration was also run on a copy of a real profile database: 511 subscription cards, 10 channel memory cards, 102 neighbour cards and 2 Home cache cards were corrected, the card counts did not change, channels such as "9to5Mac" and "10X INCOME" kept their names, and a second run changed nothing. Not run in the app yet.

Screenshots or recordings

Risk and compatibility

  • No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
  • User-facing documentation was updated where needed.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Breaking changes and upgrade steps are clearly documented.

Adds migration 0046, which rewrites saved card JSON in four tables once at startup. It never deletes rows or blanks a name. No network, playback or sync change.

@Captain-Vikram Captain-Vikram changed the title Fix/issue 423 channel byline view count fix(video): prevent view count as channel name and resolve card metadata Nov 6, 2026
2ax4 pushed a commit to 2ax4/Flow-Desktop that referenced this pull request Nov 6, 2026
…t fixes

# Conflicts:
#	src/components/video/VideoCard.test.ts
A-EDev and others added 5 commits November 10, 2026 19:21
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
… count

Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
Co-authored-by: Captain-Vikram <vighneshkontham@gmail.com>
@A-EDev A-EDev changed the title fix(video): prevent view count as channel name and resolve card metadata fix(innertube): show the channel name, not the view count, on channel tab cards Nov 10, 2026
@A-EDev
A-EDev merged commit 1ab913d into Flow-Tube:main Nov 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Videos show view count in the place of the channel

2 participants