Validate stickiness inputs for mode transition matrices - #5463
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix the public
sticky_mode_transition_matrixinput contract so malformedstickinessvalues fail deterministically instead of being silently coerced or leaking NumPy-specific exceptions.Bug
The compatibility wrapper validates
n_modesbut previously passedstickinessthrough unchanged. Consequently:True/Falsewere silently accepted as probabilities1.0/0.0.TypeError/ ambiguous-truth-value errors from NumPy rather than the documentedValueErrorcontract.Fix
stickinessto be a finite real scalar in[0, 1].The branch is based directly on current
mainand changes only the discrete-state compatibility validator and its focused regression tests.