Fix hypertoroidal MH defaults and infinite-angle handling - #5462
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
angular_errorinstead of propagating them through modulo arithmetic into NaNsBugs fixed
HypertoroidalUniformDistribution.sample_metropolis_hastings(...)inherited a default start-point path that unconditionally calledmean_direction(). Uniform distributions deliberately have no unique mean, so the sampler raised before sampling despite MH being well-defined.AbstractHypertoroidalDistribution.angular_error(...)checked only NaNs. ±infinity passed validation, thenmod(inf, 2π)produced NaN, silently contaminating the result.Validation
The branch is a two-commit, two-file change with focused regression tests. CI should exercise the repository's configured backend/test matrix.