Skip to content

Validate manifold dimensions during construction - #5461

Merged
FlorianPfaff merged 3 commits into
mainfrom
fix/manifold-constructor-dim-validation
Aug 30, 2026
Merged

Validate manifold dimensions during construction#5461
FlorianPfaff merged 3 commits into
mainfrom
fix/manifold-constructor-dim-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Problem

AbstractManifoldSpecificDistribution.__init__ wrote self._dim directly, bypassing the class's own dim setter. Public subclasses could therefore be constructed with non-positive dimensions even though assigning the same value through dim is rejected. In particular, CustomHypertoroidalDistribution(..., dim=0) constructed successfully and left a zero-dimensional manifold object in the package.

Fix

  • route constructor initialization through the existing dim setter
  • add a public-subclass regression covering zero and negative hypertoroidal dimensions

Scope

This intentionally does not overlap with the currently open hypertoroidal angular-error fix (#5459) or sparse-transition validation fix (#5460).

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 6.18s
✅ JSON prettier 7 0 0 0 0.63s
✅ JSON v8r 7 0 0 5.29s
✅ MARKDOWN markdownlint 68 0 0 0 1.83s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.37s
✅ PYTHON black 2036 1 0 0 62.16s
✅ PYTHON isort 2036 4 0 0 2.48s
✅ REPOSITORY betterleaks yes no no 1.21s
✅ REPOSITORY checkov yes no no 31.32s
✅ REPOSITORY git_diff yes no no 0.11s
✅ REPOSITORY secretlint yes no no 101.65s
✅ REPOSITORY syft yes no no 2.89s
✅ REPOSITORY trivy-sbom yes no no 2.34s
✅ YAML prettier 11 0 0 0 0.57s
✅ YAML v8r 11 0 0 16.03s
✅ YAML yamllint 11 0 0 0.92s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit 43c8a54 into main Aug 30, 2026
15 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant