Skip to content

Reject non-finite inputs in hypertoroidal angular_error #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FlorianPfaff wants to merge 2 commits into from
Closed

Reject non-finite inputs in hypertoroidal angular_error #5459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05af3c4
Reject non-finite inputs in angular_error
FlorianPfaff Aug 30, 2026
1a88ea2
Add regression test for non-finite angular_error inputs
FlorianPfaff Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pyrecest/distributions/hypertorus/abstract_hypertoroidal_distribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
cos,
int32,
int64,
isnan,
isfinite,
linspace,
log,
meshgrid,
Expand Down Expand Up @@ -171,8 +171,8 @@ def angular_error(alpha, beta):
Returns:
float or numpy array: The angular error(s) in radians.
"""
if bool(isnan(alpha).any()) or bool(isnan(beta).any()):
raise ValueError("Angles must not contain NaN values.")
if bool(backend_any(~isfinite(alpha))) or bool(backend_any(~isfinite(beta))):
raise ValueError("Angles must contain only finite values.")
# Ensure the angles are between 0 and 2*pi
alpha = mod(alpha, 2.0 * pi)
beta = mod(beta, 2.0 * pi)
Expand Down
20 changes: 20 additions & 0 deletions tests/distributions/test_hypertoroidal_angular_error_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import pytest

from pyrecest.backend import array
from pyrecest.distributions.hypertorus.abstract_hypertoroidal_distribution import (
AbstractHypertoroidalDistribution,
)


@pytest.mark.parametrize("bad_value", [float("nan"), float("inf"), float("-inf")])
@pytest.mark.parametrize("argument", ["alpha", "beta"])
def test_angular_error_rejects_nonfinite_angles(bad_value, argument):
alpha = array([0.0])
beta = array([0.0])
if argument == "alpha":
alpha = array([bad_value])
else:
beta = array([bad_value])

with pytest.raises(ValueError, match="finite"):
AbstractHypertoroidalDistribution.angular_error(alpha, beta)
Loading