Reject extra integration-bound rows for 1-D hypertori - #5458
Merged
FlorianPfaff merged 2 commits intoAug 28, 2026
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 28, 2026 19:52
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
AbstractHypertoroidalDistribution.integrate_numerically()usesAfter
atleast_2d, that condition can never reject an incorrect row count whenself.dim == 1. A 1-D circular distribution therefore accepts two or more integration-bound rows and forwards them toscipy.integrate.nquad, which turns the call into a higher-dimensional integral and can feed malformed points to the PDF instead of raising the documented boundary-count error.Fix
Require the normalized boundary row count to equal
self.dimunconditionally. This preserves the supported 1-D shorthand[lower, upper], becauseatleast_2dnormalizes it to shape(1, 2).Regression coverage
Adds a NumPy-only regression using
WrappedNormalDistributionthat verifies a 1-D distribution rejects two boundary rows with the existingone row per dimensionerror.Scope
mainatc4a857e6f84288397a186ff75849f0d0e7dfbabaLocal repository execution was not available in this environment; GitHub Actions is the authoritative validation.