Respect custom hyperspherical distance integration bounds - #5456
Merged
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 28, 2026 19:26
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
AbstractHypersphereSubsetDistribution.hellinger_distance_numerical()andtotal_variation_distance_numerical()accepted anintegration_boundariesargument and even filled in the subclass-specific full-domain default, but then discarded that value and calledintegrate_fun_over_domain(). Consequently, callers asking for a distance integral over a subset of the hypersphere silently received the full-domain distance instead.Fix
Route both distance integrands through
integrate_fun_over_domain_part(..., integration_boundaries), matchingintegrate_numerically()and preserving the existing full-domain behavior when no custom bounds are supplied.Regression
Add two non-identical S1 von Mises-Fisher distributions and verify, for both Hellinger and total-variation distance, that a strict positive-length angular subset gives a positive distance that is strictly smaller than the full-circle distance. On current
main, the partial and full values are identical because the supplied bounds are ignored.JAX skips the numerical integration regression consistently with the existing SciPy-based hyperspherical integration limitation.