Skip to content

Fix hypercylindrical integration bounds and point conditioning - #5407

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/hypercylindrical-conditioning-bounds
Aug 23, 2026
Merged

Fix hypercylindrical integration bounds and point conditioning#5407
FlorianPfaff merged 2 commits into
mainfrom
fix/hypercylindrical-conditioning-bounds

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

Fix two edge cases in AbstractHypercylindricalDistribution:

  • reject malformed or reversed static numerical integration intervals instead of forwarding them to SciPy, where reversed limits can produce negative probability mass;
  • preserve the single-point interpretation of a 1-D multidimensional periodic query after conditioning on the linear component, avoiding a column_stack row mismatch.

The conditioning helper also normalizes the analogous multidimensional linear-point shape before stacking for consistency.

Regression coverage

Adds focused tests for:

  • wrong integration-boundary count;
  • reversed integration boundaries;
  • single multidimensional periodic points after condition_on_linear;
  • single multidimensional linear points after condition_on_periodic.

This mirrors the integration-bound contract already enforced for linear and hypertoroidal distributions.

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 23, 2026 20:20
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 7.46s
✅ JSON prettier 7 0 0 0 0.82s
✅ JSON v8r 7 0 0 3.74s
✅ MARKDOWN markdownlint 68 0 0 0 2.26s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.51s
✅ PYTHON black 2013 27 0 0 58.87s
✅ PYTHON isort 2013 43 0 0 2.77s
✅ REPOSITORY betterleaks yes no no 1.53s
✅ REPOSITORY checkov yes no no 34.27s
✅ REPOSITORY git_diff yes no no 0.13s
✅ REPOSITORY secretlint yes no no 99.94s
✅ REPOSITORY syft yes no no 2.75s
✅ REPOSITORY trivy-sbom yes no no 2.63s
✅ YAML prettier 11 0 0 0 0.68s
✅ YAML v8r 11 0 0 16.19s
✅ YAML yamllint 11 0 0 0.81s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit 8c2156f into main Aug 23, 2026
14 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant