Fix discrete-state validation regressions - #5400
Merged
Merged
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 23, 2026 06:00
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix two correctness regressions in
src/pyrecest/filters/discrete_state.pythat are already covered by regression tests onmain:NaNand+inflog-emission values inscaled_emissions, while preserving-np.infas zero likelihood mass;sticky_mode_transition_matrix/mode_transition_matrix, including rejection of booleans, floats, vector-valued arrays, and timedeltas while accepting NumPy integer scalars.Why this matters
NaNand+infwere silently mapped to zero mass because all non-finite emissions shared the same handling path. This can hide upstream numerical failures and change inference results without an exception.The mode-count validation was previously fixed in #4812 but was lost when the discrete-state implementation was later consolidated into
discrete_state.py, leaving the regression tests behind.Validation
Focused validation against the existing regression cases passes locally for:
tests/filters/test_discrete_state_nonfinite_emissions.pytests/filters/test_discrete_state_mode_count_validation.pyThe patch changes only one source file (11 additions, 2 deletions).