Skip to content

Harden Daum-Huang particle-flow input validation - #5399

Merged
FlorianPfaff merged 2 commits into
mainfrom
chatgpt/fix-daum-huang-input-validation
Aug 23, 2026
Merged

Harden Daum-Huang particle-flow input validation#5399
FlorianPfaff merged 2 commits into
mainfrom
chatgpt/fix-daum-huang-input-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

Fix three correctness issues in the Daum-Huang Gaussian particle-flow helpers:

  • reject nonsymmetric covariance matrices instead of silently symmetrizing them before PSD validation;
  • reject complex-valued particles, weights, measurements, Jacobians, matrices, and schedules before NumPy float coercion can discard imaginary components;
  • validate delta_lambda as a finite nonnegative scalar in the public Gaussian bridge APIs.

Regression coverage

Adds focused tests for nonsymmetric state/measurement covariances, complex NumPy inputs, and invalid bridge exponents. Existing valid affine-bridge and EDH/LEDH behavior is unchanged.

This is independent of the currently open replay-validation, hyperhemispherical-mixture, and von-Mises-subclass PRs.

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 22, 2026 20:49
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 8.36s
✅ JSON prettier 7 0 0 0 0.7s
✅ JSON v8r 7 0 0 4.17s
✅ MARKDOWN markdownlint 68 0 0 0 2.2s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.41s
✅ PYTHON black 2009 24 0 0 64.82s
✅ PYTHON isort 2009 40 0 0 3.06s
✅ REPOSITORY betterleaks yes no no 1.33s
✅ REPOSITORY checkov yes no no 39.97s
✅ REPOSITORY git_diff yes no no 0.14s
✅ REPOSITORY secretlint yes no no 119.5s
✅ REPOSITORY syft yes no no 3.67s
✅ REPOSITORY trivy-sbom yes no no 2.47s
✅ YAML prettier 11 0 0 0 0.77s
✅ YAML v8r 11 0 0 9.78s
✅ YAML yamllint 11 0 0 1.07s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit 2612958 into main Aug 23, 2026
15 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant