Skip to content

Preserve SO(3) distribution subclasses in factories and operations - #5398

Merged
FlorianPfaff merged 3 commits into
mainfrom
chatgpt/fix-so3-subclass-preservation
Aug 23, 2026
Merged

Preserve SO(3) distribution subclasses in factories and operations#5398
FlorianPfaff merged 3 commits into
mainfrom
chatgpt/fix-so3-subclass-preservation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

Fix three subclass-erasure bugs in the SO(3) distribution APIs.

SO3BinghamDistribution.multiply, SO3BinghamDistribution.compose, and SO3TangentGaussianDistribution.from_covariance_diagonal constructed the concrete base class directly. Calling these APIs through a subclass therefore silently discarded the caller's runtime/requested type.

Changes

  • preserve the left-hand runtime type in SO(3) Bingham multiplication
  • preserve the left-hand runtime type in SO(3) Bingham composition
  • make the tangent-Gaussian diagonal-covariance factory a classmethod and construct via cls
  • add focused regression tests for all three paths

This follows the subclass-preservation convention already used by the recent Gaussian and von Mises/vMF fixes.

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 22, 2026 20:45
@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 8.4s
✅ JSON prettier 7 0 0 0 0.67s
✅ JSON v8r 7 0 0 3.64s
✅ MARKDOWN markdownlint 68 0 0 0 2.09s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.42s
✅ PYTHON black 2010 24 0 0 61.79s
✅ PYTHON isort 2010 40 0 0 2.85s
✅ REPOSITORY betterleaks yes no no 1.22s
✅ REPOSITORY checkov yes no no 35.58s
✅ REPOSITORY git_diff yes no no 0.12s
✅ REPOSITORY secretlint yes no no 104.79s
✅ REPOSITORY syft yes no no 3.67s
✅ REPOSITORY trivy-sbom yes no no 2.67s
✅ YAML prettier 11 0 0 0 0.86s
✅ YAML v8r 11 0 0 16.9s
✅ YAML yamllint 11 0 0 0.99s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff merged commit eb2457e into main Aug 23, 2026
15 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant