Preserve von Mises subclasses in factories and operations - #5397
Merged
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 22, 2026 20:42
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix a subclass-erasure bug in
VonMisesDistributionanalogous to the recently fixed vMF/Gaussian cases.from_moment,multiply, andconvolveconstructedVonMisesDistributiondirectly, so calling these APIs through a subclass silently returned the base class and discarded subclass behavior/state.Changes
from_momenta classmethod and construct viaclsmultiplypreserve the left-hand runtime typeconvolvepreserve the left-hand runtime typeRegression covered
Before this patch:
The patch makes these operations consistent with the repository's subclass-preserving distribution APIs.