Fix symmetric vMF mixture handling on the hyperhemisphere - #5396
Merged
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 22, 2026 20:34
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
set_mode(...)rather than mutating caller-owned component meansBugs
1. Asymmetric mixtures accepted by
update_identityHyperhemisphericalGridFilter.update_identity(...)documents support for a symmetric two-componentHypersphericalMixture, butmainonly checks that the mixture has two 0.5-weight components and then overwrites their means withzand-z.For two vMF components, equal weights are not sufficient for antipodal symmetry: their mean directions must be antipodal and their concentrations must match. With unequal
kappa,p(x) != p(-x), yet the hyperhemisphere update evaluates2 * meas_noise.pdf(...). That makes the likelihood depend on which antipodal representative is used.The upstream libDirectional update path also omits the equal-concentration check, while its transition-density path correctly requires equal concentrations.
Direct
.muassignment additionally mutates the caller-provided noise model and bypasses vMF unit-direction validation.2. Non-vMF mixtures interpreted as vMF system noise
sys_noise_to_transition_density(...)checks mixture weights, means, andkappa, but not the component type. A symmetric 50/50 mixture of two Watson distributions therefore passes the condition and is then evaluated using the vMF transition formula. This silently changes the model rather than rejecting an unsupported noise family.Fix
Mixture-based update/prediction paths now require:
Valid measurement components are recentered via their non-mutating
set_mode(...)API, which also validates thatzis a unit direction.Validation
Focused regressions cover:
GitHub Actions is the authoritative full backend/lint/integration validation.