Preserve hypertoroidal particle counts and axes - #5262
Open
FlorianPfaff wants to merge 2 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
HypertoroidalParticleFilterinitialized multidimensional particles with a floating-steparange(...)and then applied.squeeze().This violates the constructor's particle-count and shape contracts in two concrete cases:
n_particles=61anddim=2, NumPy produces 62 grid values, with the final value equal to2π; after toroidal wrapping this is a duplicate of zero;n_particles=1anddim>1,.squeeze()removes the particle axis, so one three-dimensional particle is stored as shape(3,)instead of(1, 3). The shared Dirac constructor then interprets the state as three scalar Diracs and creates three weights.Fix
Generate the one-dimensional angular grid with exact-count
linspace(..., num=n_particles, endpoint=False)for every dimension. For multidimensional filters, tile and transpose that grid without squeezing the batch axis.Regression coverage
(61, 2)and 61 weights;(1, 3), one weight, and a three-dimensional point estimate.Validation
2πendpoint;(1, 3)to(3,);main(f196ec41d1d8681e279936db9f1a0a3abfa276e7);