Preserve Gauss-von-Mises single-point autograd - #5255
Open
FlorianPfaff wants to merge 2 commits into
Open
Conversation
FlorianPfaff
marked this pull request as ready for review
August 6, 2026 19:42
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 02:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
GaussVonMisesDistribution.pdf(...)kept backend-native values for batched evaluation, but the single-point path returnedfloat(p[0]).On the PyTorch backend, a query tensor with
requires_grad=Truetherefore produced a Pythonfloat. The conversion silently detached the density from the computation graph, so callers could not differentiate a single-point likelihood even though the equivalent batched path remained differentiable.Fix
Return the backend scalar
p[0]directly for single-point evaluation instead of converting it to Pythonfloat.This preserves the existing numerical value while keeping the active backend's dtype, device, and autograd history.
Regression coverage
Add a PyTorch-backend regression that evaluates a single Gauss-von-Mises point with
requires_grad=Trueand verifies:Validation
float(...)returns a plain Python float and loses autograd;main(f196ec41d1d8681e279936db9f1a0a3abfa276e7) and is 2 commits ahead / 0 behind;