Skip to content

Stabilize extreme-scale PSD projection - #5254

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/stabilize-psd-projection-eigendecomposition
Open

Stabilize extreme-scale PSD projection#5254
FlorianPfaff wants to merge 2 commits into
mainfrom
agent/stabilize-psd-projection-eigendecomposition

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Bug

nearest_symmetric_psd(...) symmetrized finite inputs safely, but passed the unscaled matrix directly to numpy.linalg.eigh(...).

For a dense rank-one covariance whose entries are float64.max, the mathematical projection is the original finite matrix. NumPy's unscaled eigendecomposition instead returns an infinite leading eigenvalue, and reconstruction produces an all-inf matrix.

Fix

  • preserve the existing stable symmetrization;
  • scale the symmetric matrix and requested eigenvalue floor into a bounded range before eigendecomposition;
  • reconstruct in normalized coordinates and restore the original scale afterward;
  • preserve the existing empty-matrix behavior.

Regression coverage

Add a focused regression using a 2 x 2 matrix filled with numpy.finfo(float).max. It verifies that the projected matrix remains finite and agrees with the finite PSD input.

Validation

  • reproduced the previous all-inf projection;
  • verified the scaled implementation returns the original finite covariance;
  • compared old and new projections on randomized ordinary-scale matrices and multiple eigenvalue floors with rtol=1e-12, atol=1e-12;
  • branch is based directly on current main (f196ec41d1d8681e279936db9f1a0a3abfa276e7), 2 commits ahead and 0 behind;
  • final diff is limited to 11 changed implementation lines and one 19-line regression module.

GitHub Actions is authoritative for the full backend, lint, packaging, documentation, and integration matrix.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 29.1s
✅ JSON prettier 7 0 0 0 1.07s
✅ JSON v8r 7 0 0 3.78s
✅ MARKDOWN markdownlint 68 0 0 0 2.06s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.76s
✅ PYTHON black 1867 87 0 0 100.24s
✅ PYTHON isort 1867 141 0 0 2.91s
✅ REPOSITORY betterleaks yes no no 2.43s
✅ REPOSITORY checkov yes no no 55.25s
✅ REPOSITORY gitleaks yes no no 18.1s
✅ REPOSITORY git_diff yes no no 0.31s
✅ REPOSITORY secretlint yes no no 86.88s
✅ REPOSITORY syft yes no no 5.76s
✅ REPOSITORY trivy-sbom yes no no 6.48s
✅ REPOSITORY trufflehog yes no no 33.05s
✅ YAML prettier 11 0 0 0 0.76s
✅ YAML v8r 11 0 0 12.66s
✅ YAML yamllint 11 0 0 0.71s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review August 7, 2026 17:54
@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 7, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant