Stabilize tensor-train relative truncation - #5251
Open
FlorianPfaff wants to merge 1 commit into
Open
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 6, 2026 11:13
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
TensorTrain.from_dense(...)computed the Frobenius norm with an unscaled Euclidean norm, and_choose_rank(...)squared raw singular values while evaluating truncation tails.For large but finite tensors, those intermediate operations overflow even when the tensor, requested relative tolerance, and correct tensor-train decomposition are finite. For example,
diag(1e200, 1e200)raises under strict NumPy overflow handling; without strict handling, the resulting infinite tolerance can incorrectly collapse the decomposition to rank one.Fix
max_rankbehavior.Regression coverage
A focused test constructs
diag(1e200, 1e200)undernp.errstate(over="raise", invalid="raise"). It verifies ranks(1, 2, 1)and reconstruction of the finite input.Validation
main(f196ec41d1d8681e279936db9f1a0a3abfa276e7);