Validate hypertoroidal Fourier coefficient counts - #5243
Open
FlorianPfaff wants to merge 2 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 17:57
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
HypertoroidalFourierFilter.__init__(...)normalizedn_coefficientswith anisinstance(..., int)special case followed bytuple(int(n) for n in n_coefficients).That produced several inconsistent or silent reinterpretations:
(11.5,)was silently truncated to(11,);Truewas accepted as a one-coefficient filter becauseboolis anintsubclass;"11"was interpreted as a two-dimensional(1, 1)coefficient shape;np.int64(11)failed because it was neither a Pythonintnor iterable.These behaviors violate the documented integer coefficient-count contract and can construct a filter with a different dimensionality or resolution than the caller requested.
Fix
Reuse the established
_normalize_coefficient_shape(...)contract fromHypertoroidalFourierDistributionwithrequire_odd=Truebefore allocating the initial coefficient tensor.The filter now:
n_coefficientsparameter instead of relying on backend allocation or later distribution validation.Regression coverage
Add focused constructor tests covering:
np.int64(11);Validation
a198df740e7f05765f29e9753db2bf0fa61bb21a;main;GitHub Actions is authoritative for the full backend, lint, packaging, documentation, and integration matrix.