Skip to content

Reject masked ROI threshold inputs - #5006

Merged
FlorianPfaff merged 3 commits into
mainfrom
agent/fix-masked-roi-threshold-inputs
Aug 7, 2026
Merged

Reject masked ROI threshold inputs#5006
FlorianPfaff merged 3 commits into
mainfrom
agent/fix-masked-roi-threshold-inputs

Conversation

@FlorianPfaff

@FlorianPfaff FlorianPfaff commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • detect genuinely masked NumPy values before backend conversion in the ROI threshold compatibility hook
  • reject masked similarity entries for both Otsu and minimum-valley threshold estimation
  • reject masked nbins scalars while preserving masked-array inputs whose masks are entirely clear
  • add focused regressions for direct masks, nested masked entries, masked bin counts, and no-mask compatibility

Bug

Backend asarray conversion drops NumPy mask metadata. As a result, a value intentionally hidden by np.ma.MaskedArray could silently participate in the similarity histogram and change the selected Otsu/minimum threshold. Masked nbins values could likewise be interpreted from their hidden payload.

Rejecting genuine masks before conversion prevents hidden values from influencing ROI association thresholds.

Validation

  • Python syntax compilation of the modified compatibility module
  • isolated NumPy/SciPy behavior harness covering both threshold functions
  • final diff review: two changed files, mergeable against current main
  • GitHub Actions test, lint, security, documentation, and dependency workflows are running

Full repository and backend-matrix validation is delegated to GitHub Actions.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 23.89s
✅ JSON prettier 7 0 0 0 1.07s
✅ JSON v8r 7 0 0 3.52s
✅ MARKDOWN markdownlint 68 0 0 0 1.95s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.68s
✅ PYTHON black 1828 65 0 0 87.87s
✅ PYTHON isort 1828 99 0 0 2.69s
✅ REPOSITORY betterleaks yes no no 1.91s
✅ REPOSITORY checkov yes no no 53.21s
✅ REPOSITORY gitleaks yes no no 16.69s
✅ REPOSITORY git_diff yes no no 0.28s
✅ REPOSITORY secretlint yes no no 80.77s
✅ REPOSITORY syft yes no no 5.6s
✅ REPOSITORY trivy-sbom yes no no 5.86s
✅ REPOSITORY trufflehog yes no no 31.79s
✅ YAML prettier 11 0 0 0 0.74s
✅ YAML v8r 11 0 0 12.08s
✅ YAML yamllint 11 0 0 0.5s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff marked this pull request as ready for review August 7, 2026 18:27
@FlorianPfaff
FlorianPfaff merged commit ea89bda into main Aug 7, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant