Reject complex calibrated association features - #5004
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
CalibratedPairwiseAssociationModelvalidates named component planes as real numeric values, but its direct-featurepredict_probaadapter usedasarray(..., dtype=float64)without first checking the input dtype. Backend complex arrays can therefore lose their imaginary component during conversion and reach the classifier as different real-valued features.For example, a feature row containing
1 + 2jcan be converted to1.0rather than being rejected. This makes invalid association features produce plausible probabilities and costs instead of a deterministic validation error.Fix
predict_probafeature tensors through the existing real-numeric backend validator before flatteningRegression coverage
The new test supplies a backend-native complex feature tensor, verifies that
ValueErroris raised, and confirms that the wrapped model'spredict_probamethod is never called.Validation
main, zero commits behind, and changes only the association-feature implementation and one focused test