build(deps): bump @vitest/mocker and vitest in /app - #209
Conversation
Removes [@vitest/mocker](https://github.com/vitest-dev/vitest/tree/HEAD/packages/mocker). It's no longer used after updating ancestor dependency [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). These dependencies need to be updated together. Removes `@vitest/mocker` Updates `vitest` from 2.1.9 to 5.0.0 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.0/packages/vitest) --- updated-dependencies: - dependency-name: "@vitest/mocker" dependency-version: dependency-type: indirect - dependency-name: vitest dependency-version: 5.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![obvious-autobuild-staging[bot]](https://avatars.githubusercontent.com/u/31830338?s=60&v=4){kind=small}
There was a problem hiding this comment.
Obvious Code Review
Verdict: COMMENT
Summary
- Blocker: 1
- High: 1
- Medium: 0
npm ci fails on this PR's lockfile — npm arborist crashes (TypeError: Cannot read properties of null (reading 'edgesOut') in #loadPeerSet) while resolving node_modules/vitest on npm 10.8.2 / Node 20.20.2, the same toolchain CI uses. Reproduced locally on the PR head; master installs clean on the same machine. The repo's ci job on this PR is already failing at the same step (13s). Root cause: vitest 5.0.0 declares a non-optional peer vite ^6.4.0 || ^7.0.0 || ^8.0.0 while the repo pins vite ^5.4.11. vitest 5.0.0 additionally requires Node ^22.12.0 || ^24.0.0 || >=26.0.0 (CI pins Node 20). Treat vitest 2 → 5 as a coordinated toolchain bump (vite + Node + suite migration), not a standalone dependabot bump.
| "typescript-eslint": "^8.18.0", | ||
| "vite": "^5.4.11", | ||
| "vitest": "^2.1.8" | ||
| "vitest": "^5.0.0" |
There was a problem hiding this comment.
Blocker · reliability — This lockfile cannot install. npm ci exits 1 on npm 10.8.2 / Node 20.20.2 (the toolchain CI uses) with an arborist crash — TypeError: Cannot read properties of null (reading 'edgesOut') in #loadPeerSet, resolving node_modules/vitest; master installs clean on the same machine. The lockfile encodes vitest 5.0.0's non-optional vite ^6.4.0 || ^7.0.0 || ^8.0.0 peer against the repo's pinned vite ^5.4.11 — an internally inconsistent tree, and the repo's ci job on this PR already fails at this step. Regenerate against a version set that resolves (npm 10, Node 20), or close in favor of a coordinated bump; verify with npm ci && npm test.
| "typescript-eslint": "^8.18.0", | ||
| "vite": "^5.4.11", | ||
| "vitest": "^2.1.8" | ||
| "vitest": "^5.0.0" |
There was a problem hiding this comment.
High · reliability — vitest 5.0.0 is incompatible with the pinned toolchain: it requires Node ^22.12.0 || ^24.0.0 || >=26.0.0 (CI pins node-version: 20, @types/node is ^20) and vite ^6.4.0+ (this repo pins vite ^5.4.11). A 2 → 5 jump also needs test/config migration this diff doesn't include (the vitest config still lives in vite.config.ts's test block; all 346 tests are untouched). Scope the bump to the latest compatible release on the current toolchain, or land vitest 5 as a coordinated PR: vite ^6/^7, CI Node 22, matching @types/node, and a green full suite.
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
1 participant
Removes @vitest/mocker. It's no longer used after updating ancestor dependency vitest. These dependencies need to be updated together.
Removes
@vitest/mockerUpdates
vitestfrom 2.1.9 to 5.0.0Release notes
Sourced from vitest's releases.
... (truncated)
Commits
f441c6fchore: release v5.0.0 (#11130)d46a747fix: treat test.describe as a suite during static collection (#11128)584cf30fix: add a warning if inline project has duplicate plugins due to unexpected ...f08ce4bfix: apply queued mocks from doMock() in queue order (fixes #10706) (#11127)897f51fchore: release v5.0.0-rc.4 (#11107)1339b06chore(deps): update all non-major dependencies (#11104)51e9494feat!: parse files statically in vitest list by default (#11088)2122ffdfix: propagate --maxWorkers to projects (#11102)dc10f5ffix(browser): report the action error when a task times out (#11101)d4fe198feat: promote clearCache out of experimental (#11086)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for vitest since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.