Repository navigation
Give ReferencedInstanceValidator one MessagePack constructor - #701
Open
andrzejskowronski wants to merge 1 commit into
Open
andrzejskowronski wants to merge 1 commit into
andrzejskowronski wants to merge 1 commit into
Conversation
Firely CAR deserializes compiled schemas with MessagePack's DynamicObjectResolverAllowPrivate, which picks a single constructor per [DataContract] type. ReferencedInstanceValidator's schema and targetCases constructors both matched at four parameters, so TargetCases-form validators failed to deserialize. Add a private constructor taking all five [DataMember]s, marked [SerializationConstructor], and route the rewrite constructor through it. Add a reflection test that mirrors MessagePack's constructor pick for every assertion type and fails when it is ambiguous or leaves a [DataMember] unsettable. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new regression test does not validate attributed constructor parameters as MessagePack does.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds deterministic MessagePack deserialization for ReferencedInstanceValidator.
Changes:
- Adds a five-member serialization constructor.
- Adds reflection-based contract validation tests.
| File | Description |
|---|---|
ReferencedInstanceValidator.cs |
Defines the MessagePack constructor and reuses it for rewriting. |
MessagePackContractTests.cs |
Checks constructor selection across assertion contracts. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| yield break; | ||
| } | ||
|
|
||
| var ctorParams = chosen[0].GetParameters().Select(p => p.Name!).ToHashSet(StringComparer.OrdinalIgnoreCase); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Firely CAR deserializes compiled schemas with MessagePack's DynamicObjectResolverAllowPrivate, which picks a single constructor per [DataContract] type. ReferencedInstanceValidator's schema and targetCases constructors both matched at four parameters, so TargetCases-form validators failed to deserialize.
Adds a private constructor taking all five [DataMember]s, marked [SerializationConstructor], and route the rewrite constructor through it. Add a reflection test that mirrors MessagePack's constructor pick for every assertion type and fails when it is ambiguous or leaves a [DataMember] unsettable.