fix(ci): lowercase GHCR image ref in docker-smoke.yml - #302
Merged
Conversation
docker-smoke.yml has failed on every run since at least 2026-05-10: it did
a raw `docker pull ghcr.io/${{ github.repository }}`, which is mixed-case
(FastCrest/tether) and therefore categorically invalid per Docker's own
reference format rules. docker-publish.yml has been green throughout
because docker/metadata-action lowercases the image ref before pushing;
docker-smoke.yml just never matched that on read. Fixes by computing the
same lowercased ref once and reusing it across all four steps that
reference the image.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-smoke.ymlhas failed on every run since at least 2026-05-10 (confirmed via CI logs). It does a rawdocker pull ghcr.io/${{ github.repository }}, which resolves toFastCrest/tether, mixed-case. Docker's own client rejects this outright:invalid reference format: repository name (...) must be lowercase.docker-publish.ymlhas stayed green throughout because it builds the image reference viadocker/metadata-action, which lowercases automatically before pushing.docker-smoke.ymlnever matched that on read, so it was trying to pull an image reference that never existed.--help,targets, module-import check, and the summary).Test plan
docker-publish.ymlcompletes (or via manual dispatch), so the actual pull-and-run steps can't be exercised outside CI. The fix will be confirmed on the next tag push or manualworkflow_dispatchrun.🤖 Generated with Claude Code