Skip to content

fix: reject empty Quectel band lists and surface modem errors - #299

Open
nooblk-98 wants to merge 1 commit into
FUjr:mainfrom
NoobWRT:fix/quectel-band-validation-minimal
Open

nooblk-98 wants to merge 1 commit into
FUjr:mainfrom
NoobWRT:fix/quectel-band-validation-minimal

Conversation

@nooblk-98

Copy link
Copy Markdown

Summary

  • Reject empty/malformed Quectel band lists before sending AT commands.
  • Prevent empty selections in both LuCI interfaces while preserving other vendors’ reset behavior.
  • Report modem errors instead of false success, retaining raw responses and legacy LTE compatibility.

Minimal patch: backend, both UIs, and one existing response-fixture update. No new test scripts, CI changes, or documentation.

Verification

  • Local shell/JavaScript syntax, command-boundary, core-command, and vendor-fixture checks passed.
  • Previously tested on an Arcadyan AW1000 with a Quectel modem: empty input was rejected and reapplying the current SA band list succeeded without changing network configuration.

Replaces #298 with a clean single-commit PR. Related: nooblk-98/noobwrt-arcadyan-aw1k#43

Scope: empty-list validation and false-success reporting, not intermittent signal/status readings or the cause of connectivity loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant