Repository navigation
Rename R2 vars and derive endpoint from account ID - #11
Merged
Merged
Conversation
Rename the Cloudflare R2 secret and variable names in the asset publish workflow to use the CLOUDFLARE_R2_* prefix, and point the bucket at CLOUDFLARE_R2_BRANDING_BUCKET. Remove the separate endpoint URL variable and build the R2 endpoint from vars.CLOUDFLARE_ACCOUNT_ID instead.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Auto-approved: Renames Cloudflare R2 secret/variable names in the asset publish workflow and derives the R2 endpoint from the account ID, removing the separate endpoint variable. Bounded CI/CD configuration cleanup with no behavioral expansion.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the Cloudflare R2 secret and variable names in the asset publish workflow to use the CLOUDFLARE_R2_* prefix, and point the bucket at CLOUDFLARE_R2_BRANDING_BUCKET.
Remove the separate endpoint URL variable and build the R2 endpoint from vars.CLOUDFLARE_ACCOUNT_ID instead.