Make per_file test script use the codechecker toolchain - #266
Merged
Conversation
furtib
force-pushed
the
hotfix-toolchain-per-file
branch
from
August 5, 2026 11:01
f989b08 to
cfd14b1
Compare
furtib
force-pushed
the
hotfix-toolchain-per-file
branch
from
August 6, 2026 13:33
cfd14b1 to
6f6790c
Compare
Szelethus
approved these changes
Aug 11, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I understand its pretty hard to write a test for this; is it quite impossible?
Contributor
Author
|
We would need Bazel 9 support or a remote executor to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The test script (that runs
CodeChecker parse) for the per_file rule does not use the CodeChecker toolchain.Also reproducible by using Bazel 9 (If load statements are correctly placed).
What:
Addresses:
Fixes: #268