Skip to content

🐛 [fix] board: never build a card filed with no real acceptance criteria - #109

Open
chadhuskops wants to merge 1 commit into
EricTechPro:mainfrom
chadhuskops:fix/needs-ac
Open

chadhuskops wants to merge 1 commit into
EricTechPro:mainfrom
chadhuskops:fix/needs-ac

Conversation

@chadhuskops

Copy link
Copy Markdown

Note

⏳ Ready for review · ✅ 4/4 AC · head 22b6d20

Problem

  • Where: scripts/super-review-file-refactor.sh and scripts/super-board-wave-plan.sh
    • a. The reviewer files a refactor card whose Acceptance Criteria section is empty or holds only a placeholder
    • b. The filer sees the heading and puts it in Ready
    • c. The planner picks it, and the builder has nothing to test against
  • Who: cards filed by the reviewer (and any weak card that reaches Ready)
  • What happened: seen in a downstream run. Refactor cards with no real criteria were built

Solution

  • The refactor filer counts real items under ## Acceptance Criteria. Placeholders (TBD, TODO, <…>, …, items under 8 characters, the filer's own "Not written" line) count as zero. Zero items → needs-ac label and Backlog, even with --column Ready
  • super-board-deps.sh reports acItems per card with the same rule (it already reads every body)
  • The wave planner skips a Ready card labelled needs-ac or at acItems == 0 and lists it under flag, pointing to super-board lint. An older graph with no acItems is not held back
  • lint.md, run.md, run-workflow.md, writing-standard.md say what counts as no criteria and how to clear needs-ac
  • super-qa-file-bug.sh already refuses such bodies; super-collect only files to Backlog. Both unchanged; the planner check covers them

Acceptance criteria

  • An empty or placeholder-only AC files to Backlog with needs-ac, even with --column Ready
    ↳ tests/test-file-refactor.sh
  • acItems counts real criteria; sub-headings don't end the section
    ↳ tests/test-deps.sh scenario 19
  • The planner never picks a needs-ac or zero-AC card and flags it
    ↳ tests/test-wave-plan.sh
  • New cases fail on main and pass here
    ↳ test-file-refactor.sh 45 passed, 14 failed → 59/0; test-deps.sh and test-wave-plan.sh fail → pass with d0b7d5a's scripts swapped in. test-file-bug.sh, test-install.sh, test-merge-gate.sh, test-run-gates.sh pass

Risk

🟡 Medium · changes which cards the planner picks.

  • Door: two-way · revert and zero-AC cards are picked again
  • Blast radius: wave planning · a Ready card with no real criteria waits in flag until lint fixes it. Touches the end of tests/test-deps.sh, as does the blocked-by: none PR: whichever lands second needs a small rebase

- super-review-file-refactor.sh: an empty or placeholder-only AC section files to Backlog with `needs-ac`, even with --column Ready
- super-board-deps.sh reports `acItems`; the wave planner skips Ready cards labelled `needs-ac` or at 0 items and lists them under `flag` for lint
- lint.md, run.md, run-workflow.md and writing-standard.md say what counts as no criteria and how to clear `needs-ac`
- Seen in a downstream run: a reviewer-filed card with an empty AC was picked and the builder had nothing to test against
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants