Repository navigation
🐛 [fix] board: never build a card filed with no real acceptance criteria - #109
Open
chadhuskops wants to merge 1 commit into
Open
chadhuskops wants to merge 1 commit into
chadhuskops wants to merge 1 commit into
Conversation
- super-review-file-refactor.sh: an empty or placeholder-only AC section files to Backlog with `needs-ac`, even with --column Ready - super-board-deps.sh reports `acItems`; the wave planner skips Ready cards labelled `needs-ac` or at 0 items and lists them under `flag` for lint - lint.md, run.md, run-workflow.md and writing-standard.md say what counts as no criteria and how to clear `needs-ac` - Seen in a downstream run: a reviewer-filed card with an empty AC was picked and the builder had nothing to test against
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
⏳ Ready for review · ✅ 4/4 AC · head
22b6d20Problem
scripts/super-review-file-refactor.shandscripts/super-board-wave-plan.shSolution
## Acceptance Criteria. Placeholders (TBD,TODO,<…>,…, items under 8 characters, the filer's own "Not written" line) count as zero. Zero items →needs-aclabel and Backlog, even with--column Readysuper-board-deps.shreportsacItemsper card with the same rule (it already reads every body)needs-acor atacItems == 0and lists it underflag, pointing tosuper-board lint. An older graph with noacItemsis not held backlint.md,run.md,run-workflow.md,writing-standard.mdsay what counts as no criteria and how to clearneeds-acsuper-qa-file-bug.shalready refuses such bodies; super-collect only files to Backlog. Both unchanged; the planner check covers themAcceptance criteria
needs-ac, even with--column Ready↳
tests/test-file-refactor.shacItemscounts real criteria; sub-headings don't end the section↳
tests/test-deps.shscenario 19needs-acor zero-AC card and flags it↳
tests/test-wave-plan.shmainand pass here↳
test-file-refactor.sh45 passed, 14 failed → 59/0;test-deps.shandtest-wave-plan.shfail → pass withd0b7d5a's scripts swapped in.test-file-bug.sh,test-install.sh,test-merge-gate.sh,test-run-gates.shpassRisk
🟡 Medium · changes which cards the planner picks.
flaguntil lint fixes it. Touches the end oftests/test-deps.sh, as does theblocked-by: nonePR: whichever lands second needs a small rebase