Repository navigation
🐛 [fix] merge-gate: rerun a failed verify on the same tree before a rebase pass - #108
Open
chadhuskops wants to merge 1 commit into
Open
chadhuskops wants to merge 1 commit into
chadhuskops wants to merge 1 commit into
Conversation
…ebase pass - new config key verify_retries (default 1, 0 = old behaviour) reruns a failed verify command on the same head and base, no rebuild - a pass on retry prints `flaky: <command>` on stdout and merges; failing every try still exits 2 - seen in a downstream run: a timing-flaky test failed verify once, the card bounced to Build and the rebuilt PR was identical - config-schema.json, run.md (exit 2 routing) and project-checks.md document it; test-merge-gate.sh scenarios 26-29
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
⏳ Ready for review · ✅ 4/4 AC · head
faaf81bProblem
scripts/super-board-merge-gate.sh, the verify step before mergeSolution
verify_retries(default 1). A failed verify command reruns up to that many times on the same tree, with no rebuild and no new commitflaky: <command>on stdout and merges. Failing every try still exits 2.verify_retries: 0keeps today's behaviour. A non-integer exits 64config-schema.json,run.md(exit 2 routing) andproject-checks.mddocument itAcceptance criteria
flaky:↳
tests/test-merge-gate.shscenario 26verify_retries: 2runs the command three times;0keeps exit 2 on the first failure↳ scenarios 27, 28
verify_retriesexits 64↳ scenario 29
mainand pass here↳
bash tests/test-merge-gate.sh· fails at scenario 26 withd0b7d5a's script; PASS now.test-run-gates.sh,test_writing_format.pypassRisk
🟡 Medium · merge path.
verify_retries: 0, or revertflaky:in the output so the test can be fixed