Skip to content

🐛 [fix] deps: a bounce to Ready is never a human gate - #107

Open
chadhuskops wants to merge 1 commit into
EricTechPro:mainfrom
chadhuskops:fix/deps-bounce-none
Open

chadhuskops wants to merge 1 commit into
EricTechPro:mainfrom
chadhuskops:fix/deps-bounce-none

Conversation

@chadhuskops

Copy link
Copy Markdown

Note

⏳ Ready for review · ✅ 4/4 AC · head 5b7dcab

Problem

  • Where: scripts/super-board-deps.sh, which reads blocked-by: from card comments
    • a. A card is blocked with blocked-by: - (needs a human)
    • b. A lane later bounces it back with a ↩️ report, or writes blocked-by: - / blocked-by: none in an ordinary comment
    • c. The graph takes the last blocked-by: line from any comment, reads - as a human gate and rejects none as unparseable
  • Who: cards bounced back to Ready
  • What happened: seen in a downstream run. Rebase bounces sat as 🙋 human gates though nothing needed a human

Solution

  • blocked-by: none (any case) means no blockers
  • - gates only in a Block comment ([blocker] header, Reason tag: or older Why blocked: field). Elsewhere it reads as none
  • A newer ↩️ report with no blocked-by: line clears an older Block's line
  • block-template.md and run.md: every bounce ends with blocked-by: none; only a Block may write -

Acceptance criteria

Risk

🟡 Medium · changes which cards wait for a human.

  • Door: two-way · revert and bounces gate again
  • Blast radius: dependency graph · a hand-written blocked-by: - outside a Block comment no longer gates. Fixture 🐛 [fix] worktrees: align board workers with the path guard #22's gating comment became a proper Block. Touches the end of tests/test-deps.sh, as does the needs-ac PR: whichever lands second needs a small rebase

- `blocked-by: none` parses as no blockers instead of unparseable
- `-` gates only in a Block comment ([blocker] header, Reason tag: or Why blocked:); elsewhere it reads as none
- a newer ↩️ report with no blocked-by: line clears an older Block's line, so a rebase bounce is runnable (seen in a downstream run)
- block-template.md and run.md: every bounce ends with `blocked-by: none`; test-deps.sh scenarios 19-25
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants