Skip to content

🐛 [fix] reads: a lane's malformed or refused read fails its call, not the run - #105

Open
chadhuskops wants to merge 2 commits into
EricTechPro:mainfrom
chadhuskops:fix/github-read-caller-fail
Open

chadhuskops wants to merge 2 commits into
EricTechPro:mainfrom
chadhuskops:fix/github-read-caller-fail

Conversation

@chadhuskops

@chadhuskops chadhuskops commented Nov 12, 2026 •

Copy link
Copy Markdown

Note

⏳ Ready for review · ✅ 4/4 AC · head 5876904

Problem

  • Where: lane agents calling scripts/super-board-github-read.py
    • a. A lane reads --kind quota with a hand-written --jq, or reads a PR its token can't see (403/404), or asks GraphQL for a field that doesn't exist
    • b. 🐛 [fix] reads: malformed agent reads exit 64 instead of halting #89 made a shape miss exit 64, but only for kinds listed in FORMS; quota has none, and 403/404/bad-field errors were never treated as the caller's fault
  • Who: every lane in a wave
  • What happened: seen in a downstream run. One lane's quota read and one 403 each halted the whole run (exit 79), stopping every card

Solution

  • FORMS gains quota, so a malformed quota read exits 64 with the valid form
  • For the lane-facing kinds in FORMS, a 403/404, "Resource not accessible", "Could not resolve to a…", "Cannot query field" or "Field 'x' doesn't exist on type" exits 64 on the first attempt, with no retry
  • Still halts (79): a 401, bad token, "requires authentication" or missing scopes; rate-limit 403s still retry then halt; GraphQL error payloads still halt; SB_GITHUB_READ_STRICT=1 keeps every old halt
  • Kinds outside FORMS (issue-history, items, fields, …) serve fixed-command scripts and keep halting on a shape miss or a refusal, so super-collect's intake still stops before any write on a malformed history
  • Docstring, run-workflow.md, the wave workflow's READ_SHAPES and the lane prompt in super-board-lane.sh describe the new rule

Acceptance criteria

  • A malformed quota read fails only its call (64); script-only kinds still halt
    ↳ test_agent_shape_miss_fails_only_that_read_fixed_kinds_halt, test_collect_intake_safety.py
  • A 403/404 or bad GraphQL field fails only its call, not retried
    ↳ test_refusal_for_one_query_fails_only_that_call, test_permanent_graphql_error_is_not_retried
  • A 401 / bad token / missing scopes still halts, and strict callers still halt
    ↳ existing strict tests run under SB_GITHUB_READ_STRICT=1
  • New cases fail on main and pass here
    ↳ python3 tests/test_github_reads.py · 7 failures with d0b7d5a's script; 26 tests OK now. test_collect_intake_safety.py, test_approval.py, test-deps.sh, test-wave-plan.sh pass

Risk

🟡 Medium · changes which reads stop the run.

  • Door: two-way · revert and those reads halt the run again
  • Blast radius: lane reads on FORMS kinds · a non-strict caller now gets 64 instead of 79 for a 403/404 or bad field on those kinds. Script-only kinds and strict callers are unchanged

… the run

- a payload that misses its --kind shape exits 64 for every kind, not only those in FORMS; quota gets a form
- a 403/404, unknown GraphQL field or unresolvable resource exits 64 on the first attempt instead of halting
- a 401, bad token or missing scopes still halts at once; rate-limit 403s still retry then halt; SB_GITHUB_READ_STRICT keeps halting on all of these
- seen in a downstream run: one lane's quota --jq read and one 403 halted every card
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

…lers

- a shape miss or a 403/404 fails only the call for the lane-facing kinds in FORMS (now incl. quota); script-only kinds (issue-history, items, fields...) still halt
- keeps super-collect intake safety: a malformed issue history still stops before any write (test_collect_intake_safety.py)
- test: fixed-command kinds halt on a shape miss and on a refusal

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants