Repository navigation
🐛 [fix] reads: a lane's malformed or refused read fails its call, not the run - #105
Open
chadhuskops wants to merge 2 commits into
Open
chadhuskops wants to merge 2 commits into
chadhuskops wants to merge 2 commits into
Conversation
… the run - a payload that misses its --kind shape exits 64 for every kind, not only those in FORMS; quota gets a form - a 403/404, unknown GraphQL field or unresolvable resource exits 64 on the first attempt instead of halting - a 401, bad token or missing scopes still halts at once; rate-limit 403s still retry then halt; SB_GITHUB_READ_STRICT keeps halting on all of these - seen in a downstream run: one lane's quota --jq read and one 403 halted every card
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…lers - a shape miss or a 403/404 fails only the call for the lane-facing kinds in FORMS (now incl. quota); script-only kinds (issue-history, items, fields...) still halt - keeps super-collect intake safety: a malformed issue history still stops before any write (test_collect_intake_safety.py) - test: fixed-command kinds halt on a shape miss and on a refusal
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
⏳ Ready for review · ✅ 4/4 AC · head
5876904Problem
scripts/super-board-github-read.py--kind quotawith a hand-written--jq, or reads a PR its token can't see (403/404), or asks GraphQL for a field that doesn't existFORMS;quotahas none, and 403/404/bad-field errors were never treated as the caller's faultSolution
FORMSgainsquota, so a malformed quota read exits 64 with the valid formFORMS, a 403/404, "Resource not accessible", "Could not resolve to a…", "Cannot query field" or "Field 'x' doesn't exist on type" exits 64 on the first attempt, with no retrySB_GITHUB_READ_STRICT=1keeps every old haltFORMS(issue-history,items,fields, …) serve fixed-command scripts and keep halting on a shape miss or a refusal, so super-collect's intake still stops before any write on a malformed historyrun-workflow.md, the wave workflow'sREAD_SHAPESand the lane prompt insuper-board-lane.shdescribe the new ruleAcceptance criteria
quotaread fails only its call (64); script-only kinds still halt↳
test_agent_shape_miss_fails_only_that_read_fixed_kinds_halt,test_collect_intake_safety.py↳
test_refusal_for_one_query_fails_only_that_call,test_permanent_graphql_error_is_not_retried↳ existing strict tests run under
SB_GITHUB_READ_STRICT=1mainand pass here↳
python3 tests/test_github_reads.py· 7 failures withd0b7d5a's script; 26 tests OK now.test_collect_intake_safety.py,test_approval.py,test-deps.sh,test-wave-plan.shpassRisk
🟡 Medium · changes which reads stop the run.
FORMSkinds · a non-strict caller now gets 64 instead of 79 for a 403/404 or bad field on those kinds. Script-only kinds and strict callers are unchanged