Repository navigation
🐛 [fix] pr-body: a status block can only name its own PR's card - #104
Open
chadhuskops wants to merge 1 commit into
Open
chadhuskops wants to merge 1 commit into
chadhuskops wants to merge 1 commit into
Conversation
- Read the card from the PR's `issue-<N>-` head branch; add `--issue <N>` and refuse (exit 65) a wrong --issue or a worktree on another card - Refuse a status line naming another card's `Closes/Refs #N` or another PR's head; add `· Closes #<card>` when the line names none - Wave prompt passes `--issue`, block files live in the lane's own git dir; run.md and writing-standard.md say the same - Seen in a downstream run: parallel lanes shared a /tmp status file and the approval check refused the human's approval
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
⏳ Ready for review · ✅ 4/4 AC · head
ecd9c54Problem
scripts/super-board-pr-body.sh, the status block every lane rewrites/tmpfileCloses #Nand head, and a few carried none.super-board-approval.pythen refused the human'sdonewith "request issue is not linked to this PR" until the lines were fixed by handSolution
issue-<N>-prefix of the PR's head branch on GitHub, so the caller can't supply the wrong one--issue <N>. Exit 65 when it names another card than the PR's branch, or when the script runs in a card worktree on another card. A branch without a card prefix uses--issueCloses/Fixes/Resolves/Refs #Nor a head that isn't this PR'sCloses #N/Refs #Ngets· Closes #<card>, merged and blocked lines too.Refs #Non a partial PR is kept. Other blocks are not checked--issueand keeps block files in the lane's own git dir ($(git rev-parse --git-dir)/sb-status.md), never/tmp.run.mdandwriting-standard.mdsay the sameAcceptance criteria
Closes #Nand head) is refused, with or without the right head↳
tests/test-pr-body.shCloses, merged and blocked lines too, never on aneeds-youline↳
tests/test-pr-body.sh--issueand a card worktree both refuse another card's PR; a branch without a card takes--issue↳
tests/test-pr-body.shmainand pass here↳
bash tests/test-pr-body.sh· 40 passed, 16 failed withd0b7d5a's script; 56 passed, 0 failed now.test_writing_format.py,test-codex-wave-contract.sh,test-workflow-halt.sh,test-wave-preflight.shpassRisk
🟢 Low · one script plus prompt and docs.
Closesnow gets exit 65 and must rewrite the line