Repository navigation
Ticket batch Oct 2026: address, return DN status, stock ledger supplier columns, bilingual quotation - #6
Merged
Conversation
…us, stock ledger supplier columns, bilingual quotation - Address: unhide Phone; hide the three older duplicate Arabic fields and keep them mirrored (before_save) because live print formats still read them; patch fills whichever side is empty. - Delivery Note: patch relabels old unbilled returns from "To Bill" to "Return". - New report "Stock Ledger with Supplier Details" (supplier, supplier invoice no/date after Voucher #), bulk lookups only. - New print format "Quotation Bilingual" (EN/AR), live default left unchanged. - Tests for all of the above. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Client ticket batch (RAM tracker, Oct 2026) for
almashreq.fateherp.com(site dirram).custom_supplier_invoice_number/date), then the billing Purchase Invoice, then the delivery note. Bulk lookups, no per-row queries.Address.before_save, because live print formats (Sales Invoice -DOT,Sales Invoice-NEW, ...) still read them. Patch fills whichever side is empty; rows where both differ are logged, not overwritten.per_billed = 0from "To Bill" to "Return" (ERPNext's own rule).modifieduntouched.QUOTATION PRINT 1) is not changed. Customer ID now comes fromparty_name(the current format readsdoc.customer, which Quotations do not have, so it prints blank).Not in this PR
host_nameunset so background jobs cannot build the PDF attachment. Fix isbench --site ram set-config host_name https://almashreq.fateherp.com+ re-enable AUT-AR-00003. No code.Tested
Restored this morning's live backup into a scratch site, loaded this code from path (live apps untouched), ran
bench console:/files).Deploy (not done)
git pullonapps/ram_custom,bench --site ram migrate(runs the twov0_0_3patches + fixtures),bench --site ram clear-cache, web/workersignal QUIT. Take a backup first.🤖 Generated with Claude Code