Skip to content

Ticket batch Oct 2026: address, return DN status, stock ledger supplier columns, bilingual quotation - #6

Merged
sayanthns merged 2 commits into
mainfrom
fix/tickets-2026-10
Oct 13, 2026
Merged

sayanthns merged 2 commits into
mainfrom
fix/tickets-2026-10

Conversation

@sayanthns

Copy link
Copy Markdown
Contributor

What

Client ticket batch (RAM tracker, Oct 2026) for almashreq.fateherp.com (site dir ram).

Ticket Change
1 Stock ledger New report Stock Ledger with Supplier Details: standard Stock Ledger + Supplier, Supplier Invoice No, Supplier Invoice Date after Voucher #. Receipts use the invoice typed on the receipt (custom_supplier_invoice_number/date), then the billing Purchase Invoice, then the delivery note. Bulk lookups, no per-row queries.
3 Address Phone unhidden (Property Setter value 0). The three older duplicate Arabic fields are hidden and mirrored from the visible ones in Address.before_save, because live print formats (Sales Invoice -DOT, Sales Invoice-NEW, ...) still read them. Patch fills whichever side is empty; rows where both differ are logged, not overwritten.
5 Delivery Note return Patch relabels old submitted returns with per_billed = 0 from "To Bill" to "Return" (ERPNext's own rule). modified untouched.
8 Quotation print New print format Quotation Bilingual (fixture). Live default (QUOTATION PRINT 1) is not changed. Customer ID now comes from party_name (the current format reads doc.customer, which Quotations do not have, so it prints blank).

Not in this PR

  • Ticket 6 (Auto Repeat): cause is site config, host_name unset so background jobs cannot build the PDF attachment. Fix is bench --site ram set-config host_name https://almashreq.fateherp.com + re-enable AUT-AR-00003. No code.
  • Tickets 2 and 7: Fateh-Trading PR.

Tested

Restored this morning's live backup into a scratch site, loaded this code from path (live apps untouched), ran bench console:

  • 19 tests, 0 failed, 0 skipped. 9 deliberate breakages (each rule broken on purpose) each made at least one test fail.
  • Before/after on the restored data: return DNs "To Bill" 111 -> 0 ("Return" 247 -> 358); Arabic address pairs equal (366/366, 337/337, 356/356).
  • Quotation PDF rendered through wkhtmltopdf on the scratch site (logo and SAR glyph missing there only because the scratch host cannot serve /files).

Deploy (not done)

git pull on apps/ram_custom, bench --site ram migrate (runs the two v0_0_3 patches + fixtures), bench --site ram clear-cache, web/worker signal QUIT. Take a backup first.

🤖 Generated with Claude Code

sayanthns and others added 2 commits October 13, 2026 10:35
…us, stock ledger supplier columns, bilingual quotation

- Address: unhide Phone; hide the three older duplicate Arabic fields and keep
  them mirrored (before_save) because live print formats still read them;
  patch fills whichever side is empty.
- Delivery Note: patch relabels old unbilled returns from "To Bill" to "Return".
- New report "Stock Ledger with Supplier Details" (supplier, supplier invoice
  no/date after Voucher #), bulk lookups only.
- New print format "Quotation Bilingual" (EN/AR), live default left unchanged.
- Tests for all of the above.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sayanthns
sayanthns merged commit 8e52ed0 into main Oct 13, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant