Unpin highs - #1471
Open
tsmbland wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## asset_equalisation #1471 +/- ##
===================================================
Coverage 89.93% 89.93%
===================================================
Files 60 60
Lines 8595 8595
Branches 8595 8595
===================================================
Hits 7730 7730
Misses 545 545
Partials 320 320 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tsmbland
force-pushed
the
lexico_optimisation
branch
from
August 5, 2026 12:24
4e477bd to
ac05803
Compare
tsmbland
force-pushed
the
unpin_highs
branch
2 times, most recently
from
August 5, 2026 13:50
9de1f36 to
3e01793
Compare
11 tasks
tsmbland
changed the base branch from
lexico_optimisation
to
timeslice_equalisation
August 7, 2026 15:40
tsmbland
force-pushed
the
timeslice_equalisation
branch
2 times, most recently
from
August 11, 2026 12:13
9e118c3 to
8daa78d
Compare
tsmbland
changed the base branch from
timeslice_equalisation
to
asset_equalisation
August 11, 2026 13:59
11 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit pinning of the HiGHS solver crate versions now that the optimisation problem is sufficiently constrained to avoid platform-dependent results, addressing issue #1431.
Changes:
- Update
highsfrom an exact pin (=2.3.0) to an unpinned compatible requirement (2.4.0) and remove the directhighs-sysdependency. - Refresh
Cargo.lockto the newerhighs-sys(and related transitive) versions. - Re-enable Dependabot updates for
highs/highs-sysby removing the ignore entries.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Unpins HiGHS by moving from exact versions to a normal semver requirement and removing the direct highs-sys entry. |
| Cargo.lock | Updates the resolved dependency graph to highs 2.4.0 / highs-sys 1.15.0 and associated transitive crates. |
| .github/dependabot.yml | Stops ignoring HiGHS-related crates so Dependabot can propose future updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tsmbland
marked this pull request as ready for review
August 14, 2026 14:07
dc2917
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given that the optimisation problem is now sufficiently constrained (#1477 and #1478), we shouldn't get different results on different operating systems, or when updating highs. This PR confirms the latter point (well, at least moving from 2.3.0 to 2.4.0 - I can't guarantee that this will never be a problem). Given this, there's shouldn't be any need to pin
highsany moreFixes #1431
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks