Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical issues allow actions on stale recommendations from another node and hot-wallet spending without the promised approval step.
4 open issues
What changed in this PR
Adds configuration and review controls for NodeGuard’s automatic channel-opening workflow across the Nodes and Routing Management pages.
Changes:
- Adds per-node mode, funding wallet, channel size, and budget settings, with required-field validation.
- Displays recommendations, peer routing metrics, opening fee policies, and committed budget, with editable capacity and create/dismiss actions.
- Adds configuration warnings and shares persistence handling across routing gates.
| File | Description |
|---|---|
src/Pages/RoutingManagement.razor |
Adds the recommendations panel, budget readout, and promotion/dismissal actions. |
src/Pages/Nodes.razor |
Adds automatic channel-opening settings, validation, and updated dry-run guidance. |
Review effort: Balanced
Comment on lines
+781
to
+782
| _recommendations = recommendations.Result; | ||
| _channelOpenCommittedSats = committed.Result; |
| SetGate(node, flag, enabled); | ||
| var (ok, _) = NodeRepository.Update(node); | ||
| var capacity = GetEditedCapacity(rec); | ||
| var (ok, error) = await ChannelOpenPromotionService.Promote(rec.Id, capacity, LoggedUser.Id); |
Comment on lines
+884
to
885
| ToastService.ShowError(error ?? "Could not create the channel open request."); | ||
| return; |
Comment on lines
+844
to
+846
| In <strong>Auto</strong> mode every recommendation is promoted to a pending channel request | ||
| without review. Funding still follows the usual approval and signing flow on the Channel | ||
| Requests page. |
…anel to Routing Management
markettes
force-pushed
the
feat/simple-auto-channel-open-ui
branch
from
October 30, 2026 18:26
89d8cab to
d8dcc9b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes page, liquidity management: an Automatic Channel Opening section with the switch, mode, funding wallet, fixed channel size and budget. Wallet, size and budget are required while the feature is on, since the job skips a node missing any of them and only says so in the log.
Routing Management: a Channel open recommendations panel per node with the switch and mode, the size, the budget and what the current period has committed, and one row per open recommendation: earned fees and amount routed, refusals, outbound now over capacity, the fee policy it opens at, and an editable capacity. Create request promotes it to a pending channel open request; Dismiss starts the peer's cooldown. Peers are named from the Nodes table, like the peers table on the same page.
The panel warns when the feature is globally off or the node has no funding wallet.