tests: fix flake in test_important_plugin from sync read EBADF - #9397
Open
daywalker90 wants to merge 1 commit into
Open
tests: fix flake in test_important_plugin from sync read EBADF#9397daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
When an important plugin dies, lightningd shuts down while other plugins
may still be mid-sync-RPC during init. If rpc_open() fails because the
RPC socket is already gone (logging "Could not connect ... Connection
refused"), sync_req() proceeds with sync_fd == -1, and the subsequent
read(-1) fails with EBADF, producing the BROKEN message:
Reading sync lightningd: Bad file descriptor
This is the same intentional shutdown that already produces the
whitelisted "Reading sync lightningd: Connection reset by peer" (or a
clean EOF exit); the errno merely differs by the connection race. Add
"Bad file descriptor" to the broken_log whitelist so the test no longer
fails at teardown on this race.
Changelog-None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an important plugin dies, lightningd shuts down while other plugins may still be mid-sync-RPC during init. If
rpc_open()fails because the RPC socket is already gone (logging "Could not connect ... Connection refused"),sync_req()proceeds withsync_fd == -1, and the subsequentread(-1)fails with EBADF, producing the BROKEN message:This is the same intentional shutdown that already produces the whitelisted "Reading sync lightningd: Connection reset by peer" (or a clean EOF exit); the errno merely differs by the connection race. Add "Bad file descriptor" to the
broken_logwhitelist so the test no longer fails at teardown on this race.Fixes: #9382