chore: take kbuild 1.2.9 - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.eignex.*pins move from 1.2.8 to 1.2.9.Why
1.2.9 carries detekt 2.0.0-alpha.6. alpha.5, which 1.2.8 shipped, reports constructor parameters as
undocumented when they are documented; koblas hit it on
LuDecompositionandPivotedQrDecomposition, whose parameters all carry@propertyor@paramtags. Rewording,unwrapping a continuation line and swapping
@propertyfor@paramall left them flagged, and thesame files analyse clean under alpha.6.
Nothing else changed between 1.2.8 and 1.2.9.
Testing
CI. kbuild 1.2.9 was verified before release with a dry run of the release workflow and with
samples/smoke-test.sh, which confirms the negative samples still fail with the rule ids theyassert, so alpha.6 has not changed what the rules detect.