fix(ai-qa): stop dual delivery jobs; honor update-linked-issues on reopen - #59
Merged
Merged
Conversation
…open Canonical caller is pull_request closed + issues closed. push remains a legacy merged-delivery alias and must not be combined with PR-closed. issues.closed reopen now respects update-linked-issues=false. Co-authored-by: Hicham Zinalabdin <hichamza@users.noreply.github.com>
Hicham Zinalabdin (hichamza)
marked this pull request as ready for review
September 1, 2026 17:51
Hicham Zinalabdin (hichamza)
requested review from
Hussam Aldarwish (eduly-haldarwish)
and removed request for
a team
September 1, 2026 17:51
Hicham Zinalabdin (hichamza)
deleted the
hz/ai-qa-hygiene-bugbot-e361
branch
September 1, 2026 17:57
✅ ai-qa: PASSMerge commit
Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two Bugbot findings on the delivery-hygiene work that landed in #58.
Dual trigger (high)
The documented caller and the self-test registered both
pushtomainandpull_request: types: [closed]. Every merge therefore ran two full delivery jobs (health, review, publish, cleanup) that could race on issues and labels.Canonical caller (and self-test) is now:
pushremains a legacy merged-delivery-only alias. Do not combine it withpull_request: closed. The action still acceptspushso existing callers that cannot use PR-closed keep working; we did not skip merged PR-closed in code, because that is now the canonical path.update-linked-issuesonissues.closed(medium)The premature-reopen step ran whenever mode was
issue-closed, ignoringupdate-linked-issues. Setting that inputfalsestill reopened issues and posted comments.shouldReopenPrematureClosereturns{ reopen: false, reason: 'update-linked-issues-off' }when the flag isfalse/'false'(omit keeps the default on).inputs.update-linked-issues == 'true'.Unit tests:
node --test "ai-qa/lib/**/*.test.js"— 29 pass.✅ ai-qa: PASS
Deploy health: healthy · findings P0 0 · P1 0 · P2 0 · P3 0
Last updated by ai-qa · QA run