Skip to content

fix(ai-qa): stop dual delivery jobs; honor update-linked-issues on reopen - #59

Merged
Hicham Zinalabdin (hichamza) merged 1 commit into
mainfrom
hz/ai-qa-hygiene-bugbot-e361
Sep 1, 2026
Merged

fix(ai-qa): stop dual delivery jobs; honor update-linked-issues on reopen#59
Hicham Zinalabdin (hichamza) merged 1 commit into
mainfrom
hz/ai-qa-hygiene-bugbot-e361

Conversation

@hichamza

@hichamza Hicham Zinalabdin (hichamza) commented Sep 1, 2026

Copy link
Copy Markdown
Member

Fixes two Bugbot findings on the delivery-hygiene work that landed in #58.

Dual trigger (high)

The documented caller and the self-test registered both push to main and pull_request: types: [closed]. Every merge therefore ran two full delivery jobs (health, review, publish, cleanup) that could race on issues and labels.

Canonical caller (and self-test) is now:

on:
  pull_request:
    types: [closed]
  issues:
    types: [closed]

push remains a legacy merged-delivery-only alias. Do not combine it with pull_request: closed. The action still accepts push so existing callers that cannot use PR-closed keep working; we did not skip merged PR-closed in code, because that is now the canonical path.

update-linked-issues on issues.closed (medium)

The premature-reopen step ran whenever mode was issue-closed, ignoring update-linked-issues. Setting that input false still reopened issues and posted comments.

  • shouldReopenPrematureClose returns { reopen: false, reason: 'update-linked-issues-off' } when the flag is false / 'false' (omit keeps the default on).
  • The YAML step is gated with inputs.update-linked-issues == 'true'.
  • The script also passes the input into the policy (belt and suspenders).

Unit tests: node --test "ai-qa/lib/**/*.test.js" — 29 pass.

Open in Web Open in Cursor 

✅ ai-qa: PASS

Deploy health: healthy · findings P0 0 · P1 0 · P2 0 · P3 0

Last updated by ai-qa · QA run

…open

Canonical caller is pull_request closed + issues closed. push remains a
legacy merged-delivery alias and must not be combined with PR-closed.
issues.closed reopen now respects update-linked-issues=false.

Co-authored-by: Hicham Zinalabdin <hichamza@users.noreply.github.com>
@hichamza
Hicham Zinalabdin (hichamza) marked this pull request as ready for review September 1, 2026 17:51
@hichamza
Hicham Zinalabdin (hichamza) merged commit 85e96cd into main Sep 1, 2026
6 checks passed
@hichamza
Hicham Zinalabdin (hichamza) deleted the hz/ai-qa-hygiene-bugbot-e361 branch September 1, 2026 17:57
@mtm-bot

mtm-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ ai-qa: PASS

Merge commit 85e96cdd7cb7

Signal Result
Deploy health (https://raw.githubusercontent.com/EdulyCom/github-actions/main/README.md) ✅ healthy
QA review ⚠️ did not run — reporting deploy-health signal only
Head branch will delete hz/ai-qa-hygiene-bugbot-e361

Posted by mtm-bot[bot] · workflow run

@mtm-bot mtm-bot Bot added the ✓ /ai-qa label Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants