Repository navigation
Conversation
Render the account and options header icons through VectorIcon rather than importing react-native-vector-icons directly. The rendered glyphs, sizes and colors do not change.
The lock row and hasLock repeated the same prompt, error handling and password capture. Share them so a caller can also read the validated password from the prompt it just ran.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The handler read `validatedPassword` from its render's closure, so the value set by the prompt was invisible and the press silently stopped after unlocking. It now uses the password the prompt returns. The password lives in scene state while the unlocked flag lives in redux, so leaving Settings and coming back also left the row doing nothing. The handler now prompts whenever it has no password.
j0ntz
force-pushed
the
jon/fix/change-username-unlock
branch
from
November 1, 2026 12:30
7a69bb8 to
6b20b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Tapping Change Username while Settings is locked prompted for the password and unlocked Settings, then stopped. The user had to tap the row a second time. Every other locked row continues after the prompt.
handleChangeUsernamereadvalidatedPasswordfrom its render's closure, which hid the value set by the prompt from the running handler. It now uses the password the prompt returns.The same handler had a second dead end. The password lives in scene state and the unlocked flag lives in redux. Unlocking, leaving Settings and returning left the row doing nothing at all. The handler now prompts whenever it has no password, including when Settings already shows as unlocked.
QA found a third case in the same handler, and it predates this PR. Changing the password and then renaming in the same Settings visit passed the old password to the rename, which rebuilds the login from the value it receives. The account went back to the old password: the newest one was refused and the old one logged in. The handler now checks the held password with
account.checkPasswordand prompts when it is no longer current. It covers every way the password can change while the scene stays mounted, and an unchanged password still needs no second prompt.The first commit clears lint warnings in
SettingsScene.tsxby moving the two header icons toVectorIcon; the rendered glyphs do not change. Five other warnings in that file stay, because none has a replacement available in this scope.Tested on the iOS simulator only. The original frames show before and after for the prompt paths and stop at the Change Username scene. The new frames drive the QA case end to end on a throwaway account: change the password, rename, log in with the newest password (Home), log in with the previous password (refused). The Requirements boxes stay unchecked because no real device or Android run happened.
changeUsernamein edge-core-js does not verify the password it receives. A caller passing a stale value still rewrites the login. That is out of scope here and is a candidate for hardening in core.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
6b20b27Open Change Username after the password prompt
2026-11-01
1. before fix stays on settings
2. after fix settings locked
3. after fix password prompt
4. after fix change username scene
5. after fix cancel stays locked
6. after fix remounted unlocked
7. after fix remounted prompts
8. after fix remounted opens scene
1. c5 settings locked
2. c5 new password entered
3. c5 password changed modal
4. c5 settings after password change
5. c5 rename prompts for password
6. c5 change username opens
7. c5 settings shows new username
8. c5 login new username newest password
9. c5 newest password result
10. c5 previous password result